Merge pull request #4625 from Bnyro/master

fix: npe when opening dialog to submit sb segments
This commit is contained in:
Bnyro 2023-08-25 20:06:36 +02:00 committed by GitHub
commit 94e578dd79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -25,11 +25,8 @@ class SubmitSegmentDialog(
private val currentPosition: Long, private val currentPosition: Long,
private val duration: Long? private val duration: Long?
) : DialogFragment() { ) : DialogFragment() {
private var _binding: DialogSubmitSegmentBinding? = null
private val binding = _binding!!
override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
_binding = DialogSubmitSegmentBinding.inflate(layoutInflater) val binding = DialogSubmitSegmentBinding.inflate(layoutInflater)
binding.startTime.setText((currentPosition.toFloat() / 1000).toString()) binding.startTime.setText((currentPosition.toFloat() / 1000).toString())
@ -51,14 +48,14 @@ class SubmitSegmentDialog(
requireDialog().hide() requireDialog().hide()
lifecycleScope.launch { lifecycleScope.launch {
submitSegment() submitSegment(binding)
dismiss() dismiss()
} }
} }
} }
} }
private suspend fun submitSegment() { private suspend fun submitSegment(binding: DialogSubmitSegmentBinding) {
val context = requireContext().applicationContext val context = requireContext().applicationContext
val startTime = binding.startTime.text.toString().toFloatOrNull() val startTime = binding.startTime.text.toString().toFloatOrNull()
@ -89,9 +86,4 @@ class SubmitSegmentDialog(
context.toastFromMainDispatcher(e.localizedMessage.orEmpty()) context.toastFromMainDispatcher(e.localizedMessage.orEmpty())
} }
} }
override fun onDestroyView() {
super.onDestroyView()
_binding = null
}
} }