From f9a026af546c317abd3c1df2a0177c73635867b9 Mon Sep 17 00:00:00 2001 From: Bnyro Date: Fri, 25 Aug 2023 20:07:24 +0200 Subject: [PATCH] fix: npe when opening dialog to submit sb segments --- .../libretube/ui/dialogs/SubmitSegmentDialog.kt | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/com/github/libretube/ui/dialogs/SubmitSegmentDialog.kt b/app/src/main/java/com/github/libretube/ui/dialogs/SubmitSegmentDialog.kt index 371a60c3d..be8a42e38 100644 --- a/app/src/main/java/com/github/libretube/ui/dialogs/SubmitSegmentDialog.kt +++ b/app/src/main/java/com/github/libretube/ui/dialogs/SubmitSegmentDialog.kt @@ -25,11 +25,8 @@ class SubmitSegmentDialog( private val currentPosition: Long, private val duration: Long? ) : DialogFragment() { - private var _binding: DialogSubmitSegmentBinding? = null - private val binding = _binding!! - override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - _binding = DialogSubmitSegmentBinding.inflate(layoutInflater) + val binding = DialogSubmitSegmentBinding.inflate(layoutInflater) binding.startTime.setText((currentPosition.toFloat() / 1000).toString()) @@ -51,14 +48,14 @@ class SubmitSegmentDialog( requireDialog().hide() lifecycleScope.launch { - submitSegment() + submitSegment(binding) dismiss() } } } } - private suspend fun submitSegment() { + private suspend fun submitSegment(binding: DialogSubmitSegmentBinding) { val context = requireContext().applicationContext val startTime = binding.startTime.text.toString().toFloatOrNull() @@ -89,9 +86,4 @@ class SubmitSegmentDialog( context.toastFromMainDispatcher(e.localizedMessage.orEmpty()) } } - - override fun onDestroyView() { - super.onDestroyView() - _binding = null - } }