Clean useless database arguments (3/5)

src/invidious.cr

@@ -783,7 +783,7 @@ post "/data_control" do |env|
             next if !description
             next if !privacy
 
-            playlist = create_playlist(PG_DB, title, privacy, user)
+            playlist = create_playlist(title, privacy, user)
             Invidious::Database::Playlists.update_description(playlist.id, description)
 
             videos = item["videos"]?.try &.as_a?.try &.each_with_index do |video_id, idx|

src/invidious/playlists.cr

@@ -125,7 +125,7 @@ struct Playlist
 
       json.field "videos" do
         json.array do
-          videos = get_playlist_videos(PG_DB, self, offset: offset, locale: locale, video_id: video_id)
+          videos = get_playlist_videos(self, offset: offset, locale: locale, video_id: video_id)
           videos.each do |video|
             video.to_json(json)
           end
@@ -205,7 +205,7 @@ struct InvidiousPlaylist
             offset = self.index.index(index) || 0
           end
 
-          videos = get_playlist_videos(PG_DB, self, offset: offset, locale: locale, video_id: video_id)
+          videos = get_playlist_videos(self, offset: offset, locale: locale, video_id: video_id)
           videos.each_with_index do |video, index|
             video.to_json(json, offset + index)
           end
@@ -247,7 +247,7 @@ struct InvidiousPlaylist
   end
 end
 
-def create_playlist(db, title, privacy, user)
+def create_playlist(title, privacy, user)
   plid = "IVPL#{Random::Secure.urlsafe_base64(24)[0, 31]}"
 
   playlist = InvidiousPlaylist.new({
@@ -267,7 +267,7 @@ def create_playlist(db, title, privacy, user)
   return playlist
 end
 
-def subscribe_playlist(db, user, playlist)
+def subscribe_playlist(user, playlist)
   playlist = InvidiousPlaylist.new({
     title:       playlist.title.byte_slice(0, 150),
     id:          playlist.id,
@@ -322,7 +322,7 @@ def produce_playlist_continuation(id, index)
   return continuation
 end
 
-def get_playlist(db, plid, locale, refresh = true, force_refresh = false)
+def get_playlist(plid, locale, refresh = true, force_refresh = false)
   if plid.starts_with? "IV"
     if playlist = Invidious::Database::Playlists.select(id: plid)
       return playlist
@@ -404,7 +404,7 @@ def fetch_playlist(plid, locale)
   })
 end
 
-def get_playlist_videos(db, playlist, offset, locale = nil, video_id = nil)
+def get_playlist_videos(playlist, offset, locale = nil, video_id = nil)
   # Show empy playlist if requested page is out of range
   # (e.g, when a new playlist has been created, offset will be negative)
   if offset >= playlist.video_count || offset < 0

src/invidious/routes/api/v1/authenticated.cr

@@ -150,7 +150,7 @@ module Invidious::Routes::API::V1::Authenticated
       return error_json(400, "User cannot have more than 100 playlists.")
     end
 
-    playlist = create_playlist(PG_DB, title, privacy, user)
+    playlist = create_playlist(title, privacy, user)
     env.response.headers["Location"] = "#{HOST_URL}/api/v1/auth/playlists/#{playlist.id}"
     env.response.status_code = 201
     {

src/invidious/routes/api/v1/misc.cr

@@ -34,7 +34,7 @@ module Invidious::Routes::API::V1::Misc
     end
 
     begin
-      playlist = get_playlist(PG_DB, plid, locale)
+      playlist = get_playlist(plid, locale)
     rescue ex : InfoException
       return error_json(404, ex)
     rescue ex

src/invidious/routes/embed.cr

@@ -6,9 +6,9 @@ module Invidious::Routes::Embed
 
     if plid = env.params.query["list"]?.try &.gsub(/[^a-zA-Z0-9_-]/, "")
       begin
-        playlist = get_playlist(PG_DB, plid, locale: locale)
+        playlist = get_playlist(plid, locale: locale)
         offset = env.params.query["index"]?.try &.to_i? || 0
-        videos = get_playlist_videos(PG_DB, playlist, offset: offset, locale: locale)
+        videos = get_playlist_videos(playlist, offset: offset, locale: locale)
       rescue ex
         return error_template(500, ex)
       end
@@ -60,9 +60,9 @@ module Invidious::Routes::Embed
 
       if plid
         begin
-          playlist = get_playlist(PG_DB, plid, locale: locale)
+          playlist = get_playlist(plid, locale: locale)
           offset = env.params.query["index"]?.try &.to_i? || 0
-          videos = get_playlist_videos(PG_DB, playlist, offset: offset, locale: locale)
+          videos = get_playlist_videos(playlist, offset: offset, locale: locale)
         rescue ex
           return error_template(500, ex)
         end

src/invidious/routes/feeds.cr

@@ -265,7 +265,7 @@ module Invidious::Routes::Feeds
 
     if plid.starts_with? "IV"
       if playlist = Invidious::Database::Playlists.select(id: plid)
-        videos = get_playlist_videos(PG_DB, playlist, offset: 0, locale: locale)
+        videos = get_playlist_videos(playlist, offset: 0, locale: locale)
 
         return XML.build(indent: "  ", encoding: "UTF-8") do |xml|
           xml.element("feed", "xmlns:yt": "http://www.youtube.com/xml/schemas/2015",

src/invidious/routes/playlists.cr

@@ -50,7 +50,7 @@ module Invidious::Routes::Playlists
       return error_template(400, "User cannot have more than 100 playlists.")
     end
 
-    playlist = create_playlist(PG_DB, title, privacy, user)
+    playlist = create_playlist(title, privacy, user)
 
     env.redirect "/playlist?list=#{playlist.id}"
   end
@@ -66,8 +66,8 @@ module Invidious::Routes::Playlists
     user = user.as(User)
 
     playlist_id = env.params.query["list"]
-    playlist = get_playlist(PG_DB, playlist_id, locale)
+    playlist = get_playlist(playlist_id, locale)
-    subscribe_playlist(PG_DB, user, playlist)
+    subscribe_playlist(user, playlist)
 
     env.redirect "/playlist?list=#{playlist.id}"
   end
@@ -161,7 +161,7 @@ module Invidious::Routes::Playlists
     end
 
     begin
-      videos = get_playlist_videos(PG_DB, playlist, offset: (page - 1) * 100, locale: locale)
+      videos = get_playlist_videos(playlist, offset: (page - 1) * 100, locale: locale)
     rescue ex
       videos = [] of PlaylistVideo
     end
@@ -314,7 +314,7 @@ module Invidious::Routes::Playlists
 
     begin
       playlist_id = env.params.query["playlist_id"]
-      playlist = get_playlist(PG_DB, playlist_id, locale).as(InvidiousPlaylist)
+      playlist = get_playlist(playlist_id, locale).as(InvidiousPlaylist)
       raise "Invalid user" if playlist.author != user.email
     rescue ex
       if redirect
@@ -405,7 +405,7 @@ module Invidious::Routes::Playlists
     end
 
     begin
-      playlist = get_playlist(PG_DB, plid, locale)
+      playlist = get_playlist(plid, locale)
     rescue ex
       return error_template(500, ex)
     end
@@ -422,7 +422,7 @@ module Invidious::Routes::Playlists
     end
 
     begin
-      videos = get_playlist_videos(PG_DB, playlist, offset: (page - 1) * 100, locale: locale)
+      videos = get_playlist_videos(playlist, offset: (page - 1) * 100, locale: locale)
     rescue ex
       return error_template(500, "Error encountered while retrieving playlist videos.<br>#{ex.message}")
     end