kavin/Piped-Backend
1
0
Fork 0
mirror of https://github.com/TeamPiped/Piped-Backend.git synced 2025-04-29 08:20:30 +05:30
Code Issues Projects Releases Wiki Activity

Clean code and throw error if no video was added.

Browse Source
This commit is contained in:
Kavin 2023-01-02 20:59:57 +00:00
parent e5556f38e5
commit 48ee0bba85
No known key found for this signature in database
GPG Key ID: 49451E4482CC5BCD
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/main/java/me/kavin/piped/server/handlers/auth/AuthPlaylistHandlers.java
View File

@ -232,6 +232,8 @@ public class AuthPlaylistHandlers {
var videos = playlist.getVideos(); var videos = playlist.getVideos();
boolean added = false;
for (String videoId : videoIds) { for (String videoId : videoIds) {
if (StringUtils.isEmpty(videoId)) continue; if (StringUtils.isEmpty(videoId)) continue;
@ -255,19 +257,24 @@ public class AuthPlaylistHandlers {
s.persist(video); s.persist(video);
} catch (Exception e) { } catch (Exception e) {
// only return an error if the unavailable video is the only one in the request ExceptionHandler.handle(e);
if (videoIds.size() == 1) { continue;
return mapper.writeValueAsBytes(mapper.createObjectNode()
.put("error", "The video is either private or got deleted"));
}
} }
} }
if (playlist.getVideos().isEmpty()) playlist.setThumbnail(video.getThumbnail()); if (playlist.getVideos().isEmpty()) playlist.setThumbnail(video.getThumbnail());
added = true;
videos.add(video); videos.add(video);
} }
if (!added) {
// only return an error if no videos were added
return mapper.writeValueAsBytes(mapper.createObjectNode()
.put("error", "Unable to add any videos, since they were unable to be fetched"));
}
var tr = s.beginTransaction(); var tr = s.beginTransaction();
s.merge(playlist); s.merge(playlist);
tr.commit(); tr.commit();