Commit Graph

1299 Commits

Author SHA1 Message Date
Tobias Groza
ec3554a2ea
Merge pull request #193 from Stypox/unavailable-video-fix
Fix TeamNewPipe/NewPipe#2615
2019-09-11 21:44:05 +02:00
Stypox
24a37b88a9
Use pre-generated playerResponse field in yt's getHlsUrl()
Also refactored code to always throw exception when the url can't be found
2019-09-11 20:12:30 +02:00
Stypox
9c423a0a40
Use FORMATS to get video+audio streams on yt
Not ADAPTIVE_FORMATS
2019-09-11 20:04:28 +02:00
Stypox
e5e8c66686
Readd signature decryption in YtStreamExtractor 2019-09-11 19:56:16 +02:00
Stypox
d9570d8634
Use pre-generated playerResponse field everywhere in YtStreamExtractor 2019-09-11 19:35:08 +02:00
Stypox
63a37c48e3
Remove println left behind 2019-09-11 19:31:39 +02:00
Stypox
bf017bf5b9
Fix TeamNewPipe/NewPipe#2615 2019-09-11 19:05:41 +02:00
Vasiliy
ecb8ad85a1
Update comments 2019-09-11 19:03:53 +03:00
Andrew
d0f1c31b34
Add Invidious instances to parsing helper for YouTube 2019-09-10 17:54:32 +01:00
Vasiliy
b55c05d04f
Update frameset extractor test 2019-09-10 19:42:55 +03:00
Vasiliy
ab32b0ed84
Merge remote-tracking branch 'upstream/dev' into feature/frames 2019-09-10 19:39:58 +03:00
Vasiliy
f084cfec24
Refactor frames extraction 2019-09-10 19:38:51 +03:00
Tobias Groza
c7e9ad57c4
Merge branch 'dev' into patch-1 2019-09-09 19:05:00 +02:00
Tobias Groza
7169bcfb75
Merge pull request #192 from gzsombor/fix-illegal-expression
Fix 'java.lang.IllegalArgumentException
2019-09-03 09:12:21 +02:00
Zsombor Gegesy
93aeb19bbc Fix 'java.lang.IllegalArgumentException: Did not find balanced marker at 'class*="yt-lockup-video"'
at org.jsoup.helper.Validate.fail(Validate.java:110)'
2019-09-02 23:45:37 +02:00
Vasiliy
a6c94c7a9d
Grub frames preview from youtube 2019-08-26 19:14:09 +03:00
Christian Schabesberger
cfc72d8dc9
Merge pull request #188 from jimbo1qaz/fix-description-timestamps
Fix timestamp links in Youtube video descriptions
2019-08-22 11:25:16 +02:00
jimbo1qaz
e38d906ff9 Fix timestamp links in Youtube video descriptions
For some reason, in NewPipeExtractor,
comments were loaded from JSON by YoutubeCommentsInfoItemExtractor as text,
sent via CommentsInfoItem#getCommentText to NewPipe,
where timestamps are converted to hyperlinks using Linkify:
https://github.com/TeamNewPipe/NewPipe/pull/2168

On the other hand, video descriptions are handled in NewPipeExtractor
by scraping the watch-page HTML.
There, timestamp links were previously mangled (and now properly parsed),
before being sent as HTML via YoutubeStreamExtractor#getDescription
to NewPipe (where HTML gets converted to Spanned).

The logic introduced in this commit is different from the above PR,
since it operates in the extractor, and mutates the HTML DOM
rather than identifying via regex.
2019-08-18 01:05:41 -07:00
Christian Schabesberger
430da57350
Merge pull request #184 from Stypox/duplicate-subscription-fix
Fix inconsistency in youtube channel urls
2019-08-18 00:42:31 +02:00
Christian Schabesberger
58e3996edc
Merge branch 'dev' into duplicate-subscription-fix 2019-08-18 00:42:24 +02:00
Christian Schabesberger
f9da8bc0c8
Merge pull request #186 from Stypox/recaptcha-with-url
Add url to ReCaptchaException
2019-08-18 00:42:15 +02:00
Christian Schabesberger
3e2df12f12
Merge branch 'dev' into recaptcha-with-url 2019-08-18 00:41:27 +02:00
Christian Schabesberger
92846076ce
Merge branch 'dev' into duplicate-subscription-fix 2019-08-18 00:41:16 +02:00
Christian Schabesberger
a13304248f
Merge pull request #185 from Stypox/search-error-fix
Fix casual search error when playlists are in results
2019-08-18 00:37:59 +02:00
Stypox
06689a2f27
Add url to ReCaptchaException
Sometimes YouTube introduces recaptchas only on some pages. By adding an url to the ReCaptchaException the NewPipe app is able to use that url to load the page that originally caused the problem.
Also removed every instance of exception caught and rethrown with a different description: it makes no sense and it removes part of the useful stacktrace.
2019-08-17 09:09:07 +02:00
Stypox
d4e975e4fa
Fix search error with some playlists
Somtimes there were two divs with class "yt-lockup-meta", so the extractor couldn't get the correct one.
2019-08-16 22:47:02 +02:00
Stypox
216a4eb1f5
Complete fix inconsistency in youtube channel urls
It is not always possible to get the url in the form "https://www.youtube.com/channel/...", so a not has been added whenever that happens to be the case (i.e. only in InfoStreamItems).
2019-08-16 21:17:03 +02:00
Stypox
315c5c262f
Typo 2019-08-16 21:14:52 +02:00
Stypox
d14c45c948
Fix SoundCloud tests 2019-08-12 17:15:21 +02:00
Stypox
b09e402d4f
Fix wrong regex when channel id is at the end of the url
It had no "&" at the end.
2019-08-12 16:55:39 +02:00
Stypox
31e74253f8
Fix tests 2019-08-12 16:38:56 +02:00
Stypox
09c6822b1d
Change youtube channel url test 2019-08-12 13:13:41 +02:00
Stypox
b8bc57c53f
Add tests for youtube channel urls
They have to be in the form "https://www.youtube.com/channel/ID"
2019-08-12 11:58:50 +02:00
Stypox
6aa69a2df8
Fix inconsistency in youtube channel urls
Urls from the youtube search extractor were "https://www.youtube.com/user/NAME" instead of "https://www.youtube.com/channel/ID". This fixes TeamNewPipe/NewPipe#2167
2019-08-12 11:57:29 +02:00
Andrew
7fb17684f5
Fixed missing colon causing builds to fail 2019-08-08 00:25:42 +00:00
Andrew
5a2dcdce16
Add Invidious instances
Added all publicly listed Invidious instances from omarroth/invidious wiki page to the link handler factory for YouTube.
2019-08-08 00:19:02 +00:00
Christian Schabesberger
5f65788a2f
Merge pull request #177 from TeamNewPipe/duration_fix
fix duration can not be paresd
2019-07-31 18:03:41 +02:00
Christian Schabesberger
5798c8fdf5 fix duration can not be paresd
update gradle to version 5.1

fix sts issue for agegated videos

GOD DAMN FUCKING BULLSHIT

add duratin for controversal/age gated videos

bring back sts

remove ignores

fix ogg test
2019-07-31 16:11:42 +02:00
Christian Schabesberger
4488c21765
Merge pull request #159 from ritiek/better-soundcloud-thumbnail
Improve thumbnail quality for Soundcloud service
2019-06-27 14:27:23 +02:00
Tobias Groza
cfdbc4e1d1
Merge pull request #170 from TobiGr/dev
Fix SoundCloud playlists parsing exception
2019-06-26 01:02:34 +02:00
TobiGr
0d09a9fd61 Fix SoundCloud playlists parsing exception
Closes TeamNewPipe/NewPipe#2344
2019-06-26 00:56:03 +02:00
Tobias Groza
c64c90a567
Merge pull request #168 from masozzi/dev
soundcloud parsing helper: fixed id parser regex
2019-06-02 21:06:57 +02:00
Tobias Groza
796c1b7bc0
Merge pull request #164 from TeamNewPipe/fix/test_comments
Fix failing YouTube comments tests
2019-06-02 11:36:16 +02:00
Matteo Sozzi
93d4299f07 soundcloud parsing helper: fixed id parser regex 2019-05-31 20:15:36 +02:00
Tobias Groza
2ac713e70f
Merge pull request #160 from Stypox/invalid-youtube-subscription-fix
Fixed youtube subscription import: ignore ones with invalid url and keep ones with empty title.
2019-05-14 22:26:25 +02:00
Tobias Groza
867ca1cabf Fix failing YouTube comments tests
The comment function has been disabled for the video on which we ran the test. We are testing the comments of a different video now.
2019-05-14 22:11:40 +02:00
Tobias Groza
acebbaf073
Merge pull request #163 from Stypox/youtube-url-signature-fix
Fix invalid yt url: signature tag name is not always "signature"
2019-05-14 21:29:31 +02:00
Stypox
c70d28597b
Add fallback for urls not conaining the "sp" tag
If ever YouTube changes thing again (or uses old urls for some unknown reason), this prevents the extractor from crashing.
As suggested here: 133cc032d9 (r283529811)
2019-05-14 13:57:45 +02:00
Stypox
133cc032d9
Fix invalid yt url: signature tag name is not always "signature"
Thanks to @omarroth for the suggestion: see TeamNewPipe/NewPipeExtractor#155
2019-05-13 21:25:35 +02:00
Stypox
0eaca52c15
Add test for subscription with invalid url.
Also modified the test for empty title, since now  subscriptions with empty title are not ignored anymore.
2019-04-28 14:19:33 +02:00