mediaccc: update linkhandlers & refactor tests

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java

@@ -170,15 +170,13 @@ public class MediaCCCStreamExtractor extends StreamExtractor {
         return null;
     }
 
-    @Nonnull
     @Override
     public List<SubtitlesStream> getSubtitlesDefault() throws IOException, ExtractionException {
         return null;
     }
 
-    @Nonnull
     @Override
-    public List<SubtitlesStream> getSubtitles(MediaFormat format) throws IOException, ExtractionException {
+    public List<SubtitlesStream> getSubtitles(final MediaFormat format) throws IOException, ExtractionException {
         return null;
     }
 
@@ -212,7 +210,6 @@ public class MediaCCCStreamExtractor extends StreamExtractor {
         } catch (JsonParserException jpe) {
             throw new ExtractionException("Could not parse json returned by url: " + getLinkHandler().getUrl(), jpe);
         }
-
     }
 
     @Nonnull

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/linkHandler/MediaCCCConferenceLinkHandlerFactory.java

@@ -1,9 +1,13 @@
 package org.schabi.newpipe.extractor.services.media_ccc.linkHandler;
 
+import org.schabi.newpipe.extractor.exceptions.FoundAdException;
 import org.schabi.newpipe.extractor.exceptions.ParsingException;
 import org.schabi.newpipe.extractor.linkhandler.ListLinkHandlerFactory;
 import org.schabi.newpipe.extractor.utils.Parser;
+import org.schabi.newpipe.extractor.utils.Utils;
 
+import java.net.MalformedURLException;
+import java.net.URL;
 import java.util.List;
 
 public class MediaCCCConferenceLinkHandlerFactory extends ListLinkHandlerFactory {
@@ -14,19 +18,43 @@ public class MediaCCCConferenceLinkHandlerFactory extends ListLinkHandlerFactory
     }
 
     @Override
-    public String getId(String url) throws ParsingException {
+    public String getId(String urlString) throws ParsingException {
-        if (url.startsWith("https://api.media.ccc.de/public/conferences/")) {
+        if (urlString.startsWith("https://api.media.ccc.de/public/conferences/")) {
-            return url.replace("https://api.media.ccc.de/public/conferences/", "");
+            return urlString.replace("https://api.media.ccc.de/public/conferences/", "");
-        } else if (url.startsWith("https://media.ccc.de/c/")) {
+        } else if (urlString.startsWith("https://media.ccc.de/c/")) {
-            return Parser.matchGroup1("https://media.ccc.de/c/([^?#]*)", url);
+            return Parser.matchGroup1("https://media.ccc.de/c/([^?#]*)", urlString);
-        } else {
-            throw new ParsingException("Could not get id from url: " + url);
         }
+
+        URL url;
+        try {
+            url = Utils.stringToURL(urlString);
+        } catch (MalformedURLException e) {
+            throw new IllegalArgumentException("The given URL is not valid");
+        }
+
+        String path = url.getPath();
+        // remove leading "/" of URL-path if URL-path is given
+        if (!path.isEmpty()) {
+            path = path.substring(1);
+        }
+
+        if (path.contains("b/")) {
+            return path.substring(2);
+        }
+
+        throw new ParsingException("Could not get id from url: " + url);
+
     }
 
     @Override
     public boolean onAcceptUrl(String url) throws ParsingException {
-        return url.startsWith("https://api.media.ccc.de/public/conferences/")
+        try {
-                || url.startsWith("https://media.ccc.de/c/");
+            getId(url);
+            return true;
+        } catch (FoundAdException fe) {
+            throw fe;
+        } catch (ParsingException e) {
+            return false;
+        }
     }
 }

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/linkHandler/MediaCCCStreamLinkHandlerFactory.java

@@ -1,16 +1,39 @@
 package org.schabi.newpipe.extractor.services.media_ccc.linkHandler;
 
+import org.schabi.newpipe.extractor.exceptions.FoundAdException;
 import org.schabi.newpipe.extractor.exceptions.ParsingException;
 import org.schabi.newpipe.extractor.linkhandler.LinkHandlerFactory;
+import org.schabi.newpipe.extractor.utils.Utils;
+
+import java.net.MalformedURLException;
+import java.net.URL;
 
 public class MediaCCCStreamLinkHandlerFactory extends LinkHandlerFactory {
 
     @Override
-    public String getId(String url) throws ParsingException {
+    public String getId(String urlString) throws ParsingException {
-        if (url.startsWith("https://api.media.ccc.de/public/events/") &&
+        if (urlString.startsWith("https://api.media.ccc.de/public/events/") &&
-                !url.contains("?q=")) {
+                !urlString.contains("?q=")) {
-            return url.replace("https://api.media.ccc.de/public/events/", "");
+            return urlString.replace("https://api.media.ccc.de/public/events/", "");
         }
+
+        URL url;
+        try {
+            url = Utils.stringToURL(urlString);
+        } catch (MalformedURLException e) {
+            throw new IllegalArgumentException("The given URL is not valid");
+        }
+
+        String path = url.getPath();
+        // remove leading "/" of URL-path if URL-path is given
+        if (!path.isEmpty()) {
+            path = path.substring(1);
+        }
+
+        if (path.contains("v/")) {
+            return path.substring(2);
+        }
+
         throw new ParsingException("Could not get id from url: " + url);
     }
 
@@ -21,7 +44,13 @@ public class MediaCCCStreamLinkHandlerFactory extends LinkHandlerFactory {
 
     @Override
     public boolean onAcceptUrl(String url) throws ParsingException {
-        return url.startsWith("https://api.media.ccc.de/public/events/") &&
+        try {
-                !url.contains("?q=");
+            getId(url);
+            return true;
+        } catch (FoundAdException fe) {
+            throw fe;
+        } catch (ParsingException e) {
+            return false;
+        }
     }
 }

extractor/src/test/java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCConferenceExtractorTest.java

@@ -4,47 +4,86 @@ import org.junit.BeforeClass;
 import org.junit.Test;
 import org.schabi.newpipe.DownloaderTestImpl;
 import org.schabi.newpipe.extractor.NewPipe;
-import org.schabi.newpipe.extractor.channel.ChannelExtractor;
 import org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCConferenceExtractor;
 
 import static junit.framework.TestCase.assertEquals;
+import static junit.framework.TestCase.assertTrue;
 import static org.schabi.newpipe.extractor.ServiceList.MediaCCC;
 
 /**
  * Test {@link MediaCCCConferenceExtractor}
  */
 public class MediaCCCConferenceExtractorTest {
-    private static ChannelExtractor extractor;
 
-    @BeforeClass
+    public static class FrOSCon2017 {
-    public static void setUpClass() throws Exception {
+        private static MediaCCCConferenceExtractor extractor;
-        NewPipe.init(DownloaderTestImpl.getInstance());
+
-        extractor = MediaCCC.getChannelExtractor("https://api.media.ccc.de/public/conferences/froscon2017");
+        @BeforeClass
-        extractor.fetchPage();
+        public static void setUpClass() throws Exception {
+            NewPipe.init(DownloaderTestImpl.getInstance());
+            extractor = (MediaCCCConferenceExtractor) MediaCCC.getChannelExtractor("https://media.ccc.de/c/froscon2017");
+            extractor.fetchPage();
+        }
+
+        @Test
+        public void testName() throws Exception {
+            assertEquals("FrOSCon 2017", extractor.getName());
+        }
+
+        @Test
+        public void testGetUrl() throws Exception {
+            assertEquals("https://api.media.ccc.de/public/conferences/froscon2017", extractor.getUrl());
+        }
+
+        @Test
+        public void testGetOriginalUrl() throws Exception {
+            assertEquals("https://media.ccc.de/c/froscon2017", extractor.getOriginalUrl());
+        }
+
+        @Test
+        public void testGetThumbnailUrl() throws Exception {
+            assertEquals("https://static.media.ccc.de/media/events/froscon/2017/logo.png", extractor.getAvatarUrl());
+        }
+
+        @Test
+        public void testGetInitalPage() throws Exception {
+            assertEquals(97, extractor.getInitialPage().getItems().size());
+        }
     }
 
-    @Test
+    public static class Oscal2019 {
-    public void testName() throws Exception {
+        private static MediaCCCConferenceExtractor extractor;
-        assertEquals("FrOSCon 2017", extractor.getName());
-    }
 
-    @Test
+        @BeforeClass
-    public void testGetUrl() throws Exception {
+        public static void setUpClass() throws Exception {
-        assertEquals("https://api.media.ccc.de/public/conferences/froscon2017", extractor.getUrl());
+            NewPipe.init(DownloaderTestImpl.getInstance());
-    }
+            extractor = (MediaCCCConferenceExtractor) MediaCCC.getChannelExtractor("https://media.ccc.de/c/oscal19");
+            extractor.fetchPage();
+        }
 
-    @Test
+        @Test
-    public void testGetOriginalUrl() throws Exception {
+        public void testName() throws Exception {
-        assertEquals("https://media.ccc.de/c/froscon2017", extractor.getOriginalUrl());
+            assertEquals("Open Source Conference Albania 2019", extractor.getName());
-    }
+        }
 
-    @Test
+        @Test
-    public void testGetThumbnailUrl() throws Exception {
+        public void testGetUrl() throws Exception {
-        assertEquals("https://static.media.ccc.de/media/events/froscon/2017/logo.png", extractor.getAvatarUrl());
+            assertEquals("https://api.media.ccc.de/public/conferences/oscal19", extractor.getUrl());
-    }
+        }
 
-    @Test
+        @Test
-    public void testGetInitalPage() throws Exception {
+        public void testGetOriginalUrl() throws Exception {
-        assertEquals(97, extractor.getInitialPage().getItems().size());
+            assertEquals("https://media.ccc.de/c/oscal19", extractor.getOriginalUrl());
+        }
+
+        @Test
+        public void testGetThumbnailUrl() throws Exception {
+            assertEquals("https://static.media.ccc.de/media/events/oscal/2019/oscal-19.png", extractor.getAvatarUrl());
+        }
+
+        @Test
+        public void testGetInitalPage() throws Exception {
+            assertTrue(extractor.getInitialPage().getItems().size() >= 21);
+        }
     }
 }

extractor/src/test/java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCStreamExtractorTest.java

@@ -1,101 +1,179 @@
 package org.schabi.newpipe.extractor.services.media_ccc;
 
+import com.grack.nanojson.JsonObject;
 import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.schabi.newpipe.DownloaderTestImpl;
 import org.schabi.newpipe.extractor.NewPipe;
+import org.schabi.newpipe.extractor.exceptions.ExtractionException;
 import org.schabi.newpipe.extractor.exceptions.ParsingException;
-import org.schabi.newpipe.extractor.services.BaseExtractorTest;
 import org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCStreamExtractor;
-import org.schabi.newpipe.extractor.stream.StreamExtractor;
 
+import java.io.IOException;
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.Calendar;
 
 import static java.util.Objects.requireNonNull;
 import static junit.framework.TestCase.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.schabi.newpipe.extractor.ServiceList.MediaCCC;
 
 /**
  * Test {@link MediaCCCStreamExtractor}
  */
-public class MediaCCCStreamExtractorTest implements BaseExtractorTest {
+public class MediaCCCStreamExtractorTest {
-    private static StreamExtractor extractor;
 
-    @BeforeClass
+    public static class Gpn18Tmux {
-    public static void setUpClass() throws Exception {
+        private static MediaCCCStreamExtractor extractor;
-        NewPipe.init(DownloaderTestImpl.getInstance());
 
-        extractor = MediaCCC.getStreamExtractor("https://api.media.ccc.de/public/events/8afc16c2-d76a-53f6-85e4-90494665835d");
+        @BeforeClass
-        extractor.fetchPage();
+        public static void setUpClass() throws Exception {
+            NewPipe.init(DownloaderTestImpl.getInstance());
+
+            extractor = (MediaCCCStreamExtractor) MediaCCC.getStreamExtractor("https://media.ccc.de/v/gpn18-105-tmux-warum-ein-schwarzes-fenster-am-bildschirm-reicht");
+            extractor.fetchPage();
+        }
+
+        @Test
+        public void testServiceId() throws Exception {
+            assertEquals(2, extractor.getServiceId());
+        }
+
+        @Test
+        public void testName() throws Exception {
+            assertEquals("tmux - Warum ein schwarzes Fenster am Bildschirm reicht", extractor.getName());
+        }
+
+        @Test
+        public void testId() throws Exception {
+            assertEquals("gpn18-105-tmux-warum-ein-schwarzes-fenster-am-bildschirm-reicht", extractor.getId());
+        }
+
+        @Test
+        public void testUrl() throws Exception {
+            assertEquals("https://api.media.ccc.de/public/events/gpn18-105-tmux-warum-ein-schwarzes-fenster-am-bildschirm-reicht", extractor.getUrl());
+        }
+
+        @Test
+        public void testOriginalUrl() throws Exception {
+            assertEquals("https://media.ccc.de/v/gpn18-105-tmux-warum-ein-schwarzes-fenster-am-bildschirm-reicht", extractor.getOriginalUrl());
+        }
+
+        @Test
+        public void testThumbnail() throws Exception {
+            assertEquals("https://static.media.ccc.de/media/events/gpn/gpn18/105-hd.jpg", extractor.getThumbnailUrl());
+        }
+
+        @Test
+        public void testUploaderName() throws Exception {
+            assertEquals("gpn18", extractor.getUploaderName());
+        }
+
+        @Test
+        public void testUploaderUrl() throws Exception {
+            assertEquals("https://api.media.ccc.de/public/conferences/gpn18", extractor.getUploaderUrl());
+        }
+
+        @Test
+        public void testUploaderAvatarUrl() throws Exception {
+            assertEquals("https://static.media.ccc.de/media/events/gpn/gpn18/logo.png", extractor.getUploaderAvatarUrl());
+        }
+
+        @Test
+        public void testVideoStreams() throws Exception {
+            assertEquals(4, extractor.getVideoStreams().size());
+        }
+
+        @Test
+        public void testAudioStreams() throws Exception {
+            assertEquals(2, extractor.getAudioStreams().size());
+        }
+
+        @Test
+        public void testGetTextualUploadDate() throws ParsingException {
+            Assert.assertEquals("2018-05-11T02:00:00.000+02:00", extractor.getTextualUploadDate());
+        }
+
+        @Test
+        public void testGetUploadDate() throws ParsingException, ParseException {
+            final Calendar instance = Calendar.getInstance();
+            instance.setTime(new SimpleDateFormat("yyyy-MM-dd").parse("2018-05-11"));
+            assertEquals(instance, requireNonNull(extractor.getUploadDate()).date());
+        }
     }
 
-    @Override
+    public static class _36c3PrivacyMessaging {
-    public void testServiceId() throws Exception {
+        private static MediaCCCStreamExtractor extractor;
-        assertEquals(2, extractor.getServiceId());
-    }
 
-    @Override
+        @BeforeClass
-    public void testName() throws Exception {
+        public static void setUpClass() throws Exception {
-        assertEquals("tmux - Warum ein schwarzes Fenster am Bildschirm reicht", extractor.getName());
+            NewPipe.init(DownloaderTestImpl.getInstance());
-    }
+            extractor = (MediaCCCStreamExtractor) MediaCCC.getStreamExtractor("https://media.ccc.de/v/36c3-10565-what_s_left_for_private_messaging");
+            extractor.fetchPage();
+        }
 
-    @Override
+        @Test
-    public void testId() throws Exception {
+        public void testName() throws Exception {
-        assertEquals("", extractor.getId());
+            assertEquals("What's left for private messaging?", extractor.getName());
-    }
+        }
 
-    @Override
+        @Test
-    public void testUrl() throws Exception {
+        public void testId() throws Exception {
-        assertEquals("", extractor.getUrl());
+            assertEquals("36c3-10565-what_s_left_for_private_messaging", extractor.getId());
-    }
+        }
 
-    @Override
+        @Test
-    public void testOriginalUrl() throws Exception {
+        public void testUrl() throws Exception {
-        assertEquals("", extractor.getOriginalUrl());
+            assertEquals("https://api.media.ccc.de/public/events/36c3-10565-what_s_left_for_private_messaging", extractor.getUrl());
-    }
+        }
 
-    @Test
+        @Test
-    public void testThumbnail() throws Exception {
+        public void testOriginalUrl() throws Exception {
-        assertEquals("https://static.media.ccc.de/media/events/gpn/gpn18/105-hd.jpg", extractor.getThumbnailUrl());
+            assertEquals("https://media.ccc.de/v/36c3-10565-what_s_left_for_private_messaging", extractor.getOriginalUrl());
-    }
+        }
 
-    @Test
+        @Test
-    public void testUploaderName() throws Exception {
+        public void testThumbnail() throws Exception {
-        assertEquals("gpn18", extractor.getUploaderName());
+            assertEquals("https://static.media.ccc.de/media/congress/2019/10565-hd.jpg", extractor.getThumbnailUrl());
-    }
+        }
 
-    @Test
+        @Test
-    public void testUploaderUrl() throws Exception {
+        public void testUploaderName() throws Exception {
-        assertEquals("https://api.media.ccc.de/public/conferences/gpn18", extractor.getUploaderUrl());
+            assertEquals("36c3", extractor.getUploaderName());
-    }
+        }
 
-    @Test
+        @Test
-    public void testUploaderAvatarUrl() throws Exception {
+        public void testUploaderUrl() throws Exception {
-        assertEquals("https://static.media.ccc.de/media/events/gpn/gpn18/logo.png", extractor.getUploaderAvatarUrl());
+            assertEquals("https://api.media.ccc.de/public/conferences/36c3", extractor.getUploaderUrl());
-    }
+        }
 
-    @Test
+        @Test
-    public void testVideoStreams() throws Exception {
+        public void testUploaderAvatarUrl() throws Exception {
-        assertEquals(4, extractor.getVideoStreams().size());
+            assertEquals("https://static.media.ccc.de/media/congress/2019/logo.png", extractor.getUploaderAvatarUrl());
-    }
+        }
 
-    @Test
+        @Test
-    public void testAudioStreams() throws Exception {
+        public void testVideoStreams() throws Exception {
-        assertEquals(2, extractor.getAudioStreams().size());
+            assertEquals(8, extractor.getVideoStreams().size());
-    }
+        }
 
-    @Test
+        @Test
-    public void testGetTextualUploadDate() throws ParsingException {
+        public void testAudioStreams() throws Exception {
-        Assert.assertEquals("2018-05-11T02:00:00.000+02:00", extractor.getTextualUploadDate());
+            assertEquals(2, extractor.getAudioStreams().size());
-    }
+        }
 
-    @Test
+        @Test
-    public void testGetUploadDate() throws ParsingException, ParseException {
+        public void testGetTextualUploadDate() throws ParsingException {
-        final Calendar instance = Calendar.getInstance();
+            Assert.assertEquals("2020-01-11T01:00:00.000+01:00", extractor.getTextualUploadDate());
-        instance.setTime(new SimpleDateFormat("yyyy-MM-dd").parse("2018-05-11"));
+        }
-        assertEquals(instance, requireNonNull(extractor.getUploadDate()).date());
+
+        @Test
+        public void testGetUploadDate() throws ParsingException, ParseException {
+            final Calendar instance = Calendar.getInstance();
+            instance.setTime(new SimpleDateFormat("yyyy-MM-dd").parse("2020-01-11"));
+            assertEquals(instance, requireNonNull(extractor.getUploadDate()).date());
+        }
     }
-}
+}