From 6aabdc6d16b31a739918e4eca5d06e87b4cfa353 Mon Sep 17 00:00:00 2001 From: FireMasterK <20838718+FireMasterK@users.noreply.github.com> Date: Sun, 12 Sep 2021 01:09:10 +0530 Subject: [PATCH] Fix for requested changes. --- .../youtube/extractors/YoutubeCommentsExtractor.java | 5 ++--- .../youtube/extractors/YoutubeCommentsInfoItemExtractor.java | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java index eb4432a39..d5f65264e 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java @@ -215,12 +215,11 @@ public class YoutubeCommentsExtractor extends CommentsExtractor { contents.remove(index); } - String jsonKey = contents.getObject(0).has("commentThreadRenderer") ? "commentThreadRenderer" : "commentRenderer"; + final String jsonKey = contents.getObject(0).has("commentThreadRenderer") ? "commentThreadRenderer" : "commentRenderer"; final List comments; try { - comments = JsonUtils.getValues(contents, - jsonKey); + comments = JsonUtils.getValues(contents, jsonKey); } catch (final Exception e) { throw new ParsingException("Unable to get parse youtube comments", e); } diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java index e7cc02360..29a3dd937 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java @@ -250,7 +250,7 @@ public class YoutubeCommentsInfoItemExtractor implements CommentsInfoItemExtract final String id = JsonUtils.getString(JsonUtils.getArray(json, "replies.commentRepliesRenderer.contents").getObject(0), "continuationItemRenderer.continuationEndpoint.continuationCommand.token"); return new Page(url, id); } catch (final Exception e) { - return null; + return null; // Would return null for Comment Replies, since YouTube does not support nested replies. } } }