Remove public modifier from tests

This commit is contained in:
litetex 2025-01-27 22:24:15 +01:00
parent e475b2971b
commit 625e9f96d2
No known key found for this signature in database
GPG Key ID: 525B43E6039B3689

View File

@ -26,8 +26,7 @@ import java.util.List;
/** /**
* Test for {@link YoutubeSubscriptionExtractor} * Test for {@link YoutubeSubscriptionExtractor}
*/ */
public class YoutubeSubscriptionExtractorTest { class YoutubeSubscriptionExtractorTest {
private static YoutubeSubscriptionExtractor subscriptionExtractor; private static YoutubeSubscriptionExtractor subscriptionExtractor;
private static LinkHandlerFactory urlHandler; private static LinkHandlerFactory urlHandler;
@ -41,7 +40,7 @@ public class YoutubeSubscriptionExtractorTest {
} }
@Test @Test
public void testFromInputStream() throws Exception { void testFromInputStream() throws Exception {
final List<SubscriptionItem> subscriptionItems = subscriptionExtractor.fromInputStream( final List<SubscriptionItem> subscriptionItems = subscriptionExtractor.fromInputStream(
new FileInputStream(resolveTestResource("youtube_takeout_import_test.json"))); new FileInputStream(resolveTestResource("youtube_takeout_import_test.json")));
assertEquals(7, subscriptionItems.size()); assertEquals(7, subscriptionItems.size());
@ -55,14 +54,14 @@ public class YoutubeSubscriptionExtractorTest {
} }
@Test @Test
public void testEmptySourceException() throws Exception { void testEmptySourceException() throws Exception {
final List<SubscriptionItem> items = subscriptionExtractor.fromInputStream( final List<SubscriptionItem> items = subscriptionExtractor.fromInputStream(
new ByteArrayInputStream("[]".getBytes(StandardCharsets.UTF_8))); new ByteArrayInputStream("[]".getBytes(StandardCharsets.UTF_8)));
assertTrue(items.isEmpty()); assertTrue(items.isEmpty());
} }
@Test @Test
public void testSubscriptionWithEmptyTitleInSource() throws Exception { void testSubscriptionWithEmptyTitleInSource() throws Exception {
final String source = "[{\"snippet\":{\"resourceId\":{\"channelId\":\"UCEOXxzW2vU0P-0THehuIIeg\"}}}]"; final String source = "[{\"snippet\":{\"resourceId\":{\"channelId\":\"UCEOXxzW2vU0P-0THehuIIeg\"}}}]";
final List<SubscriptionItem> items = subscriptionExtractor.fromInputStream( final List<SubscriptionItem> items = subscriptionExtractor.fromInputStream(
new ByteArrayInputStream(source.getBytes(StandardCharsets.UTF_8))); new ByteArrayInputStream(source.getBytes(StandardCharsets.UTF_8)));
@ -74,7 +73,7 @@ public class YoutubeSubscriptionExtractorTest {
} }
@Test @Test
public void testSubscriptionWithInvalidUrlInSource() throws Exception { void testSubscriptionWithInvalidUrlInSource() throws Exception {
final String source = "[{\"snippet\":{\"resourceId\":{\"channelId\":\"gibberish\"},\"title\":\"name1\"}}," + final String source = "[{\"snippet\":{\"resourceId\":{\"channelId\":\"gibberish\"},\"title\":\"name1\"}}," +
"{\"snippet\":{\"resourceId\":{\"channelId\":\"UCEOXxzW2vU0P-0THehuIIeg\"},\"title\":\"name2\"}}]"; "{\"snippet\":{\"resourceId\":{\"channelId\":\"UCEOXxzW2vU0P-0THehuIIeg\"},\"title\":\"name2\"}}]";
final List<SubscriptionItem> items = subscriptionExtractor.fromInputStream( final List<SubscriptionItem> items = subscriptionExtractor.fromInputStream(
@ -87,8 +86,8 @@ public class YoutubeSubscriptionExtractorTest {
} }
@Test @Test
public void testInvalidSourceException() { void testInvalidSourceException() {
List<String> invalidList = Arrays.asList( final List<String> invalidList = Arrays.asList(
"<xml><notvalid></notvalid></xml>", "<xml><notvalid></notvalid></xml>",
"<opml><notvalid></notvalid></opml>", "<opml><notvalid></notvalid></opml>",
"{\"a\":\"b\"}", "{\"a\":\"b\"}",
@ -100,13 +99,14 @@ public class YoutubeSubscriptionExtractorTest {
"\uD83D\uDC28\uD83D\uDC28\uD83D\uDC28", "\uD83D\uDC28\uD83D\uDC28\uD83D\uDC28",
"gibberish"); "gibberish");
for (String invalidContent : invalidList) { for (final String invalidContent : invalidList) {
try { try {
byte[] bytes = invalidContent.getBytes(StandardCharsets.UTF_8); final byte[] bytes = invalidContent.getBytes(StandardCharsets.UTF_8);
subscriptionExtractor.fromInputStream(new ByteArrayInputStream(bytes)); subscriptionExtractor.fromInputStream(new ByteArrayInputStream(bytes));
fail("Extracting from \"" + invalidContent + "\" didn't throw an exception"); fail("Extracting from \"" + invalidContent + "\" didn't throw an exception");
} catch (final Exception e) { } catch (final Exception e) {
boolean correctType = e instanceof SubscriptionExtractor.InvalidSourceException; final boolean correctType =
e instanceof SubscriptionExtractor.InvalidSourceException;
if (!correctType) { if (!correctType) {
e.printStackTrace(); e.printStackTrace();
} }
@ -117,7 +117,7 @@ public class YoutubeSubscriptionExtractorTest {
private static void assertSubscriptionItems(final List<SubscriptionItem> subscriptionItems) private static void assertSubscriptionItems(final List<SubscriptionItem> subscriptionItems)
throws Exception { throws Exception {
assertTrue(subscriptionItems.size() > 0); assertTrue(!subscriptionItems.isEmpty());
for (final SubscriptionItem item : subscriptionItems) { for (final SubscriptionItem item : subscriptionItems) {
assertNotNull(item.getName()); assertNotNull(item.getName());
@ -128,7 +128,7 @@ public class YoutubeSubscriptionExtractorTest {
} }
@Test @Test
public void fromZipInputStream() throws Exception { void fromZipInputStream() throws Exception {
final List<String> zipPaths = Arrays.asList( final List<String> zipPaths = Arrays.asList(
"youtube_takeout_import_test_1.zip", "youtube_takeout_import_test_1.zip",
"youtube_takeout_import_test_2.zip" "youtube_takeout_import_test_2.zip"
@ -144,13 +144,13 @@ public class YoutubeSubscriptionExtractorTest {
} }
@Test @Test
public void fromCsvInputStream() throws Exception { void fromCsvInputStream() throws Exception {
final List<String> csvPaths = Arrays.asList( final List<String> csvPaths = Arrays.asList(
"youtube_takeout_import_test_1.csv", "youtube_takeout_import_test_1.csv",
"youtube_takeout_import_test_2.csv" "youtube_takeout_import_test_2.csv"
); );
for (String path : csvPaths) for (final String path : csvPaths)
{ {
final File file = resolveTestResource(path); final File file = resolveTestResource(path);
final FileInputStream fileInputStream = new FileInputStream(file); final FileInputStream fileInputStream = new FileInputStream(file);