Commit Graph

3047 Commits

Author SHA1 Message Date
Ankur
b698699679 Fix [PlaylistFragment]: resolve stuttering at bottom of scroll
-Removed ScrollView. RecyclerView itself handles scrolling, nesting it inside a ScrollView is possibly leading to conflicting scrolling behavior effecting performance(i.e stuttering when scrolling at bottom and updating list with new data items).

-Used AppBarLayout and CollapsingToolbarLayout as containers for content(image etc) above list of video items. Together with CoordinatorLayout, these components streamline scrolling behavior and UI interactions with each other and RecyclerView.
2024-02-06 20:22:50 -08:00
Ankur
277ad0d62d Fix [ChannelFragment]: swipe refresh only at top of scroll
Implemented listeners to provide distinction between scrolling upward and swiping to refresh layout. When a user scrolls up, the refresh layout is only triggered once they are at the top of the scroll.
2024-02-06 17:15:29 -08:00
Ankur
5d65725ead Fix [ChannelFragment]: resolve stuttering at bottom of scroll
-Removed ScrollView. RecyclerView itself handles scrolling, nesting it inside a ScrollView is possibly leading to conflicting scrolling behavior effecting performance(i.e stuttering when scrolling at bottom and updating list with new data items).

-Used AppBarLayout and CollapsingToolbarLayout as containers for content(banner etc) above list of videos items. Together with CoordinatorLayout, these components streamline scrolling behavior and UI interactions with each other and RecyclerView.
2024-02-06 16:17:52 -08:00
Bnyro
b6669cf65d refactor: merge PiP and pause on quit preference into one 2024-02-05 17:22:16 +01:00
Bnyro
f9fa732cb4
Merge pull request #5587 from manish99verma/Give-up-timer-on-long-buffering
feat: stop loading after long unsuccessful buffering
2024-02-05 16:47:13 +01:00
Manish Kumar Verma
7db816d612 feat: Give up timer on long buffering
Stops buffering after 10 minutes
2024-02-05 16:46:08 +01:00
Bnyro
2bde360518 refactor: simplify home view model logic 2024-02-05 16:31:18 +01:00
Jt90-spec
d4802d175e fix: Resolve homepage not loading when 'trending' is not selected among home tab content 2024-02-05 16:31:18 +01:00
Isira Seneviratne
3166df3496 fix: Remove inappropriate runBlocking call 2024-02-03 17:30:08 +05:30
Bnyro
60cf879202 fix: crash when importing a playlist whose id already exists 2024-02-01 15:30:21 +01:00
Bnyro
6948d48612
Merge pull request #5575 from nik-conder/fix
fix: correctly display colors in system panel
2024-01-31 16:10:32 +01:00
Nikita
43eed17c9d fix: correctly display colors in system panel 2024-01-31 16:08:46 +01:00
Isira Seneviratne
28e653120f refactor: Simplify getVideoIdFromUrl 2024-01-31 06:25:28 +05:30
Isira Seneviratne
939668d3b8
Merge pull request #5569 from Isira-Seneviratne/Collection
refactor: Avoid boxing for segment pair
2024-01-30 05:52:33 +05:30
Bnyro
25ef9ec318
Merge pull request #5565 from arkibax/also-clear-watch-positions
feat: add option to also clear watch positions when clearing history in the watch history screen
2024-01-29 17:32:24 +01:00
Isira Seneviratne
59385b0c73 refactor: Avoid boxing for segment pair 2024-01-29 05:27:55 +05:30
arkibax
c94a3ff526 added string resource 2024-01-27 10:25:03 +01:00
Isira Seneviratne
9b963a3e28
refactor: Simplify ContentFilter toggling (#5544)
* refactor: Simplify ContentFilter toggling

* refactor: Update backup helper

* fix: Handle old content filter preference if present

* Add todo comment
2024-01-27 09:30:47 +05:30
arkibax
8287e87785 feat: add option to also clear watch positions when clearing history in the watch history screen 2024-01-26 21:13:21 +01:00
Manish Kumar Verma
9fc80a2877
fix: clearing watch positions doesn't works sometimes (#5557) 2024-01-26 18:50:35 +01:00
Bnyro
3f391c3795
Merge pull request #5561 from Bnyro/master
fix: player seekbar can be hard to grab
2024-01-26 14:47:10 +01:00
Bnyro
e6abf05cb3 fix: player seekbar can be hard to grab 2024-01-26 14:46:48 +01:00
Bnyro
3d96e22844
Merge pull request #5560 from Bnyro/master
fix: playing queue actions still visible after miniplayer closed by swipe
2024-01-26 14:23:10 +01:00
Bnyro
e807d0dcdc fix: playing queue actions still visible after miniplayer closed by swipe 2024-01-26 14:22:47 +01:00
Bnyro
c086379959
Merge pull request #5559 from Bnyro/master
fix: don't toggle system bars in player fragment when locking player
2024-01-26 14:20:04 +01:00
Bnyro
a5af986c13 fix: don't toggle system bars in player fragment when locking player 2024-01-26 14:19:35 +01:00
Isira Seneviratne
858dbe7ede
refactor: Rewrite search functionality using Paging (#5528)
* refactor: Rewrite search functionality using Paging

* Apply code review comments

* Update app/src/main/java/com/github/libretube/ui/adapters/SearchChannelAdapter.kt

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>

* Apply code review suggestions

---------

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>
2024-01-25 15:30:40 +05:30
Bnyro
5813b9284a
Merge pull request #5542 from manish99verma/manish99verma-replay_from_notification
fix: Replay video from notification player
2024-01-24 17:51:22 +01:00
Manish Kumar Verma
9b7dcfacf3 fix: Replay video from notification player 2024-01-24 00:47:58 +05:30
Isira Seneviratne
588ef35296 refactor: Add parcelableArrayList extension 2024-01-23 16:48:51 +05:30
Vedant.R.J.Chourey
02d30f1f17 feat: add delete all button for downloads 2024-01-22 19:34:17 +01:00
Isira Seneviratne
81d3e32582
Merge pull request #5529 from Isira-Seneviratne/Simplify_DeArrow
refactor: Simplify dearrow process
2024-01-22 19:45:04 +05:30
Bnyro
385f12a1d8 fix: switch back to home bookmarks layout on home screen 2024-01-22 14:41:52 +01:00
Bnyro
c32506887c
Merge pull request #5515 from IndusAryan/vm
feat(ui): save scroll position in trends
2024-01-22 14:19:17 +01:00
IndusAryan
c8e921de16 feat(ui): save scroll position in trends 2024-01-22 14:18:51 +01:00
Bnyro
6616ad40bf refactor: store notification ids in an enum 2024-01-22 14:12:00 +01:00
Bnyro
16c7986469 feat: support for downloading whole playlist at once 2024-01-22 14:00:04 +01:00
Isira Seneviratne
3724f8d123 refactor: Simplify dearrow process 2024-01-22 09:22:55 +05:30
Bnyro
88a1679315 refactor: remember video feed, don't auto reload 2024-01-20 20:31:22 +01:00
RafaRamos
e31943f5ab
feat: Improve new user experience + adjust home load (#5491)
* Added necessary translations

* Added support for redirecting directly to IntentSettings

* Create HomeViewModel

* Used HomeViewModel

* Update app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>

* Update app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>

* Update app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>

* Swap elvis operator for if statement for improved readability.

* Move runSafely to separate file

* Change when statement by if statement

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>

* Format if statement

* * Remove LiveData properties;
* Change buttons style for consistency;
* Move updateIfChanged to a separate file;

---------

Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>
2024-01-19 16:03:17 +01:00
Bnyro
338ef22a18 refactor: simplify initalization of MutableLiveData in PlayerViewModel.kt 2024-01-18 17:26:47 +01:00
Bnyro
ec8c9bad4b
Merge pull request #5498 from IndusAryan/mvvm
feat: seperate trends fragment into a viewmodel to improve ux
2024-01-18 17:14:12 +01:00
IndusAryan
eda53bea03 refactor: use a view model for the trends fragment 2024-01-18 17:13:29 +01:00
Bnyro
ed48f0ca49 feat: option to shuffle downloads in background 2024-01-17 17:45:30 +01:00
RafaRamos
2290951a4d Clear views on VideoAdapter' onBindViewHolder 2024-01-16 12:03:40 +01:00
Bnyro
4cd6552c38
Merge pull request #5486 from abGit9/Show_Channel_Page
fix: don't show history when closing video on channel page
2024-01-15 18:03:24 +01:00
Bnyro
1876fa643c feat: add 'hide watched videos' to feed filter options 2024-01-15 18:00:43 +01:00
Ankur
c781de4e60 fix: Show Channel Page 2024-01-13 19:09:58 -08:00
Isira Seneviratne
f2ab8435e5
Merge pull request #5484 from Isira-Seneviratne/Simplify_NetworkHelper
refactor: Simplify NetworkHelper
2024-01-13 06:11:30 +05:30
Isira Seneviratne
98043d341a
Merge pull request #5483 from Isira-Seneviratne/HDR_check_improvement
refactor: Improve HDR check
2024-01-13 06:11:12 +05:30
RafaRamos
444eb693d4
feat: Support multiple filter selection (#5478)
Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>
2024-01-12 15:56:17 +01:00
Isira Seneviratne
f74c4394b1 refactor: Simplify NetworkHelper 2024-01-12 05:32:29 +05:30
Isira Seneviratne
8bd59db843 refactor: Improve HDR check 2024-01-12 05:15:39 +05:30
Bnyro
0e960e1a6c
Merge pull request #5482 from Bnyro/master
feat: support for exporting and importing channel groups
2024-01-11 20:25:43 +01:00
Bnyro
d46c030242 feat: support for exporting and importing channel groups 2024-01-11 20:25:26 +01:00
RafaRamos
769919bb7c Fix instance reload on instance changed in settings. 2024-01-11 16:39:45 +01:00
Isira Seneviratne
1e375350eb Simplify dearrow using TreeSet 2024-01-09 12:25:56 +05:30
Bnyro
94f9be7297
Merge pull request #5464 from Bnyro/master
feat: show duration in downloads and improve downloads UI
2024-01-08 20:02:09 +01:00
Bnyro
d7f95cd23d feat: show duration in downloads and improve downloads UI 2024-01-08 20:01:48 +01:00
Bnyro
aea631bb01
Merge pull request #5463 from Bnyro/master
feat: show repeat button in audio player when playback finished
2024-01-08 19:17:34 +01:00
Bnyro
46acd28c26 feat: show repeat button in audio player when playback finished 2024-01-08 19:17:09 +01:00
Bnyro
8b8eacd405
Merge pull request #5460 from RafaelsRamos/fix/5459
fix: Erratic navbar and miniplayer behaviour.
2024-01-08 19:02:47 +01:00
Bnyro
73c98368a7 fix: improve solo queue repetition performance and make independent of autoplay 2024-01-08 19:01:16 +01:00
RafaRamos
f245d7ef5b Ensure mini-player is only closed when swiping strictly down, from the collapsed state. 2024-01-08 11:31:25 +01:00
Bnyro
8ab491afa7 fix: can't open channel from player fragment 2024-01-06 21:19:11 +01:00
Bnyro
4c1604a646 fix: only apply white image background to channel avatars 2024-01-06 14:23:03 +01:00
Bnyro
3661cd82f7 fix: can't open playlists 2024-01-06 14:19:17 +01:00
Bnyro
9c2abeeca1
Merge pull request #5443 from RafaelsRamos/imp/feed
fix: Improve home feed layout and fix issue where incorrect cache size was defaulted.
2024-01-06 14:03:31 +01:00
RafaRamos
0e927b4b18 Fix issue where no caching was being done by default. 2024-01-06 14:03:07 +01:00
Bnyro
c4da395b58
Merge pull request #5425 from RafaelsRamos/feat/5418
feat: Support setting sleep timer on Audio player
2024-01-06 14:00:24 +01:00
Bnyro
c63cd09c83
Merge pull request #5436 from RafaelsRamos/fix/2548
fix: Improve player to mini-player transition + bottom space when there are no navigation tabs
2024-01-06 13:56:42 +01:00
Bnyro
6a8e2c004d
Merge pull request #5435 from RafaelsRamos/fix/5410
fix: Audio Pausing on quickly volume level adjustment
2024-01-06 13:49:52 +01:00
Bnyro
07b657692c chore: limit max amount of concurrent downloads to 6 to prevent rate limiting 2024-01-06 13:28:51 +01:00
Bnyro
de99c2e824 fix: correctly display transparent channelImages 2024-01-06 13:23:11 +01:00
RafaRamos
7a30741664 Ensure no main navigation scene is performed if there are no tabs. 2024-01-04 16:06:09 +01:00
RafaRamos
b7550b903b Create function to check if there are Navigation bars. 2024-01-04 16:05:28 +01:00
RafaRamos
71631413c4 Reset isMoving on ACTION_DOWN event 2024-01-04 11:03:15 +01:00
Bnyro
217b50c293
Merge pull request #5424 from synicalico/patch-1
fix: crash on download menu
2024-01-03 17:39:38 +01:00
FineFindus
784d7909d3 Ensure correct actions management. 2024-01-03 16:30:24 +01:00
RafaRamos
bccac2a0ab Redirect to Sleep timer bottom sheet, on Sleep timer icon click. 2024-01-03 14:05:29 +01:00
synicalico
bf25909972
fix: crash on download menu 2024-01-03 17:31:57 +08:00
Bnyro
759e31f906 fix: remove unnecessary subscription status api call in channel fragment 2023-12-30 17:23:31 +01:00
Bnyro
2e551c8226 fix: regressions by persistent notification lifecycle fix 2023-12-30 16:20:46 +01:00
RafaRamos
65f113c445
fix: ensure correct persistent notification lifecycle (#5388)
Co-authored-by: Bnyro <bnyro@tutanota.com>
2023-12-30 16:11:30 +01:00
Isira Seneviratne
37de6a7374
Merge pull request #5380 from Isira-Seneviratne/Navigation_safe_args
refactor: Use Navigation Safe Args
2023-12-29 06:47:50 +05:30
Bnyro
6edc161cd4 feat: start playing video when using add to queue action if queue empty 2023-12-28 18:31:48 +01:00
Bnyro
a6c82662c1 fix: don't auto-add live videos to the playing queue 2023-12-28 18:25:52 +01:00
RafaRamos
84dbabe23e Supports close video on MiniPlayer swipe down 2023-12-26 16:31:40 +01:00
Bnyro
7221126e1d
Merge pull request #5386 from RafaelsRamos/fix/5361
fix: oldest videos repeatedly displayed when loading channel videos
2023-12-26 12:02:34 +01:00
RafaRamos
4782c24185 Fix infinite repeated videos load on ChannelFragment.kt 2023-12-24 11:55:39 +01:00
Isira Seneviratne
b70e2c2630 refactor: Use SoftwareKeyboardControllerCompat 2023-12-24 08:01:41 +05:30
Bnyro
fe59526b60
Merge pull request #5383 from Bnyro/master
fix: add to playlist dialog doesnt show any playlists
2023-12-23 11:04:55 +01:00
Bnyro
b5c10774e0 fix: add to playlist dialog doesnt show any playlists 2023-12-23 11:04:20 +01:00
Bnyro
ac02961cb6
Merge pull request #5382 from Bnyro/master
fix: crash when playing deleted playlist in background
2023-12-23 10:49:21 +01:00
Bnyro
31ba48e539 fix: crash when playing deleted playlist in background 2023-12-23 10:48:46 +01:00
Isira Seneviratne
8f13d13084
Merge pull request #5379 from Isira-Seneviratne/ClipboardHelper
refactor: Improve ClipboardHelper
2023-12-23 15:13:05 +05:30
Bnyro
f86eaccf95
Merge pull request #5381 from Bnyro/master
fix: clicking now playing notification in offline player opens audio player
2023-12-23 10:40:31 +01:00
Bnyro
998abf8252 fix: clicking now playing notification in offline player opens audio player 2023-12-23 10:33:22 +01:00
Isira Seneviratne
f573ec7434 refactor: Use Navigation Safe Args 2023-12-23 08:10:26 +05:30
Isira Seneviratne
8301e9d4f8 refactor: Improve ClipboardHelper 2023-12-23 07:46:42 +05:30
Bnyro
5c8bcc5fe1
Merge pull request #5364 from FineFindus/feat/copy-video-id
feat: add copy video ID button in stats sheet
2023-12-21 22:21:45 +01:00
FineFindus
cbb8b01d63
refactor: assert that context is non-null 2023-12-21 22:14:22 +01:00
RafaRamos
f60375a110
feat: add "Rich caption rendering" setting (#5371) 2023-12-21 18:33:38 +01:00
IndusAryan
1e67660879
refactor(fix): fix black screen and delay when unsetting fullscreen (#5367) 2023-12-21 16:34:08 +01:00
Bnyro
9f4a11ba37 refactor: simplify the dropdown menu component 2023-12-21 14:26:15 +01:00
Bnyro
5297d870a9 fix: crash in add to playlist dialog if playlists empty 2023-12-21 14:16:27 +01:00
FineFindus
a8903d8a2a
style: run ktlint 2023-12-20 19:22:57 +01:00
FineFindus
39f9fb07f5
feat(player/stats-dialog): add copy button to video id 2023-12-20 19:22:38 +01:00
Bnyro
df50f1c612 feat: separate landscape grid columns pref + more impacted adapters 2023-12-19 15:59:41 +01:00
Bnyro
2cbeedce6e feat: add preset to use 1.75x playback speed 2023-12-19 15:20:42 +01:00
Bnyro
d4f8af0883 feat: show instance regions, uptime and registration status in settings 2023-12-17 17:10:35 +01:00
Bnyro
1a5b74cab3 feat: display the instance uptime on initial instance selection 2023-12-17 16:47:34 +01:00
Bnyro
c545d744bd refactor: base option sheets selections on their string resource ids 2023-12-17 16:36:22 +01:00
Bnyro
8edef3583c fix: don't use dead fallback instances api anymore 2023-12-17 16:29:07 +01:00
Bnyro
9566de68be feat: quick actions to add a channel to a group 2023-12-15 16:15:00 +01:00
Bnyro
a7cbced326 style: various player UI improvements, fix navigation bar color 2023-12-15 15:03:59 +01:00
Bnyro
74e291c1dd fix: download sheet share dialog shares channel instead of video 2023-12-14 18:48:10 +01:00
Bnyro
e5b56bee90 fix: home tab content not included in preferences backup 2023-12-08 22:46:01 +01:00
Bnyro
85dc55fc57 fix: crash in channel fragment when binding already recycled 2023-12-08 13:18:39 +01:00
Isira Seneviratne
3c13ec0c46
Merge pull request #5305 from Isira-Seneviratne/TypedArray_use
refactor: Use TypedArray.use() extension
2023-12-08 04:56:25 +05:30
Isira Seneviratne
16abbe6b3a refactor: Use TypedArray.use() extension 2023-12-07 19:51:19 +05:30
Bnyro
3a576a9999
Merge pull request #5301 from Bnyro/master
style: new player layout and various UI improvements
2023-12-06 15:30:22 +01:00
Bnyro
d00299bea7 style: new player layout and various UI improvements 2023-12-06 15:29:30 +01:00
Bnyro
593dd9ed4f
Merge pull request #5300 from Bnyro/master
fix: improve download speeds and anonymity
2023-12-06 14:40:10 +01:00
Bnyro
9e415bbe23 fix: improve download speeds and anonymity 2023-12-06 14:39:50 +01:00
Bnyro
9b72432153
Merge pull request #5299 from Bnyro/master
refactor: match the size of continue watching and related streams
2023-12-06 14:21:50 +01:00
Bnyro
c807d1d54d refactor: match the size of continue watching and related streams 2023-12-06 14:21:09 +01:00
Bnyro
05f09cdc69
Merge pull request #5297 from Bnyro/master
fix: can't play videos when Piped proxy disabled
2023-12-06 14:16:00 +01:00
Bnyro
e465c313ac fix: can't play videos when Piped proxy disabled 2023-12-06 14:15:29 +01:00
Isira Seneviratne
94ca6c5e06 refactor: Improve view binding 2023-12-05 05:15:21 +05:30
Bnyro
fa65d3998f feat: automatically play the next downloaded video in offline audio mode 2023-12-04 16:20:37 +01:00
Bnyro
eb4744ceb1 refactor: support outdated Piped instance versions 2023-12-04 16:00:45 +01:00
Bnyro
a821aec028 feat: render html and css in captions 2023-12-04 15:41:54 +01:00
Bnyro
82a278792a fix: crash when player fragment is being destroyed 2023-12-04 15:10:58 +01:00
Bnyro
2ac5f1b0a2 refactor: simplify channel page and tabs logic 2023-11-29 16:34:33 +01:00
Bnyro
9d7e5c2a24 fix: don't fail to load channel page when auth instance down 2023-11-29 15:49:21 +01:00
HritikBhat
8d1c13ce70
fix: text animation slowly fades out when collapsing description (#5236) 2023-11-28 18:29:45 +01:00
Bnyro
acb8e8ec03 refactor: remove bottom reached toast and show progress indicator instead 2023-11-27 20:23:58 +01:00
Bnyro
10e3db8d45 fix: crash when deleting account 2023-11-27 19:51:04 +01:00
Bnyro
10f32e37a9 fix: player resolution updates upexpectedly on fullscreen change 2023-11-23 17:05:51 +01:00
Isira Seneviratne
e715833e1e
Merge pull request #5212 from Isira-Seneviratne/Notification_batch
refactor: Use batch notification API
2023-11-22 21:40:48 +05:30
Isira Seneviratne
f0a0261e4b refactor: Use batch notification API 2023-11-22 19:23:11 +05:30
Bnyro
61d85033ee
Merge pull request #5204 from Bnyro/sleep-timer
feat: new sleep timer (integrated into the player UI)
2023-11-19 15:14:35 +01:00
Bnyro
867f2ac087 feat: new sleep timer (integrated into the player UI) 2023-11-19 15:14:21 +01:00
Bnyro
d3d0cc917a
Merge pull request #5200 from saymanrifat/saymanrifat-5095-subtitle-optz
fix: increase subtitle font size in fullscreen
2023-11-19 10:58:46 +01:00
Sayman Rifat
05e9bf2920 fix: Increase subtitle font size in fullscreen 2023-11-19 10:58:07 +01:00
Bnyro
22c44c32cc fix: missing horizontal padding for player in landscape 2023-11-19 09:48:44 +01:00
Bnyro
c7f4cbc312
Merge pull request #5197 from Bnyro/master
fix: share dialog doesn't use shortened yt links for videos
2023-11-18 17:44:59 +01:00
Bnyro
e5bde82076 fix: share dialog doesn't use shortened yt links for videos 2023-11-18 17:44:33 +01:00
Isira Seneviratne
4d577d463f
Merge pull request #5186 from Isira-Seneviratne/listOfNotNull
refactor: Use listOfNotNull
2023-11-18 13:34:33 +05:30