kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2025-04-29 08:20:32 +05:30
Code Issues Projects Releases Wiki Activity

feat: add "Rich caption rendering" setting (#5371)

Browse Source
This commit is contained in:
RafaRamos 2023-12-21 18:33:38 +01:00 committed by GitHub
parent 1e67660879
commit f60375a110
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/com/github/libretube/constants/PreferenceKeys.kt
View File

@ -71,6 +71,7 @@ object PreferenceKeys {
const val SEARCH_HISTORY_TOGGLE = "search_history_toggle" const val SEARCH_HISTORY_TOGGLE = "search_history_toggle"
const val SYSTEM_CAPTION_STYLE = "system_caption_style" const val SYSTEM_CAPTION_STYLE = "system_caption_style"
const val CAPTION_SETTINGS = "caption_settings" const val CAPTION_SETTINGS = "caption_settings"
const val RICH_CAPTION_RENDERING = "rich_caption_rendering"
const val SEEK_INCREMENT = "seek_increment" const val SEEK_INCREMENT = "seek_increment"
const val DEFAULT_RESOLUTION = "default_res" const val DEFAULT_RESOLUTION = "default_res"
const val DEFAULT_RESOLUTION_MOBILE = "default_res_mobile" const val DEFAULT_RESOLUTION_MOBILE = "default_res_mobile"

6
app/src/main/java/com/github/libretube/helpers/PlayerHelper.kt
View File

@ -165,6 +165,12 @@ object PlayerHelper {
true true
) )
val useRichCaptionRendering: Boolean
get() = PreferenceHelper.getBoolean(
PreferenceKeys.RICH_CAPTION_RENDERING,
false
)
private val bufferingGoal: Int private val bufferingGoal: Int
get() = PreferenceHelper.getString( get() = PreferenceHelper.getString(
PreferenceKeys.BUFFERING_GOAL, PreferenceKeys.BUFFERING_GOAL,

2
app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt
View File

@ -605,8 +605,8 @@ open class CustomExoPlayerView(
val captionStyle = PlayerHelper.getCaptionStyle(context) val captionStyle = PlayerHelper.getCaptionStyle(context)
subtitleView?.apply { subtitleView?.apply {
setApplyEmbeddedFontSizes(false) setApplyEmbeddedFontSizes(false)
setViewType(SubtitleView.VIEW_TYPE_WEB)
setFixedTextSize(Cue.TEXT_SIZE_TYPE_ABSOLUTE, PlayerHelper.captionsTextSize) setFixedTextSize(Cue.TEXT_SIZE_TYPE_ABSOLUTE, PlayerHelper.captionsTextSize)
if (PlayerHelper.useRichCaptionRendering) setViewType(SubtitleView.VIEW_TYPE_WEB)
if (!PlayerHelper.useSystemCaptionStyle) return if (!PlayerHelper.useSystemCaptionStyle) return
setApplyEmbeddedStyles(captionStyle == CaptionStyleCompat.DEFAULT) setApplyEmbeddedStyles(captionStyle == CaptionStyleCompat.DEFAULT)
setStyle(captionStyle) setStyle(captionStyle)

2
app/src/main/res/values/strings.xml
View File

@ -223,6 +223,8 @@
<string name="watch_positions_title">Remembered playback positions</string> <string name="watch_positions_title">Remembered playback positions</string>
<string name="reset_watch_positions">Reset</string> <string name="reset_watch_positions">Reset</string>
<string name="system_caption_style">System caption style</string> <string name="system_caption_style">System caption style</string>
<string name="rich_caption_rendering">Rich caption rendering</string>
<string name="rich_caption_rendering_summary">Render web captions for a more rich and customized experience.</string>
<string name="captions">Captions</string> <string name="captions">Captions</string>
<string name="none">None</string> <string name="none">None</string>
<string name="general">General</string> <string name="general">General</string>

7
app/src/main/res/xml/player_settings.xml
View File

@ -123,6 +123,13 @@
app:key="caption_settings" app:key="caption_settings"
app:title="@string/caption_settings" /> app:title="@string/caption_settings" />
<SwitchPreferenceCompat
android:icon="@drawable/ic_caption"
app:defaultValue="false"
app:key="rich_caption_rendering"
app:title="@string/rich_caption_rendering"
android:summary="@string/rich_caption_rendering_summary"/>
</PreferenceCategory> </PreferenceCategory>
<PreferenceCategory app:title="@string/queue"> <PreferenceCategory app:title="@string/queue">