diff --git a/app/src/main/java/com/github/libretube/fragments/PlayerFragment.kt b/app/src/main/java/com/github/libretube/fragments/PlayerFragment.kt index 7b9bf0ca9..0feca3e6a 100644 --- a/app/src/main/java/com/github/libretube/fragments/PlayerFragment.kt +++ b/app/src/main/java/com/github/libretube/fragments/PlayerFragment.kt @@ -253,8 +253,8 @@ class PlayerFragment : Fragment() { } view.findViewById(R.id.player_title_layout).setOnClickListener { - val image = view.findViewById(R.id.player_description_arrow) - image.animate().rotationBy(180F).setDuration(100).start() + val arrowImageView = view.findViewById(R.id.player_description_arrow) + arrowImageView.animate().rotationBy(180F).setDuration(100).start() if (playerDescription.isVisible) { playerDescription.visibility = View.GONE } else { diff --git a/app/src/main/java/com/github/libretube/fragments/Subscriptions.kt b/app/src/main/java/com/github/libretube/fragments/Subscriptions.kt index 8e18b9715..077b5415e 100644 --- a/app/src/main/java/com/github/libretube/fragments/Subscriptions.kt +++ b/app/src/main/java/com/github/libretube/fragments/Subscriptions.kt @@ -6,9 +6,6 @@ import android.util.Log import android.view.LayoutInflater import android.view.View import android.view.ViewGroup -import android.view.animation.Animation -import android.view.animation.LinearInterpolator -import android.view.animation.RotateAnimation import android.widget.ImageView import android.widget.ProgressBar import android.widget.RelativeLayout @@ -79,9 +76,13 @@ class Subscriptions : Fragment() { } var toggleSubs = view.findViewById(R.id.toggle_subs) + val arrowImageView = view.findViewById(R.id.toggle) + toggleSubs.visibility = View.VISIBLE var loadedSubbedChannels = false + toggleSubs.setOnClickListener { + arrowImageView.animate().rotationBy(180F).setDuration(100).start() if (!channelRecView.isVisible) { if (!loadedSubbedChannels) { channelRecView?.layoutManager = LinearLayoutManager(context) @@ -90,21 +91,6 @@ class Subscriptions : Fragment() { } channelRecView.visibility = View.VISIBLE feedRecView.visibility = View.GONE - - // toggle button - val rotate = RotateAnimation( - 0F, - 180F, - Animation.RELATIVE_TO_SELF, - 0.5f, - Animation.RELATIVE_TO_SELF, - 0.5f - ) - rotate.duration = 100 - rotate.interpolator = LinearInterpolator() - rotate.fillAfter = true - val image = view.findViewById(R.id.toggle) - image.startAnimation(rotate) } else { channelRecView.visibility = View.GONE feedRecView.visibility = View.VISIBLE diff --git a/app/src/main/java/com/github/libretube/preferences/MainSettings.kt b/app/src/main/java/com/github/libretube/preferences/MainSettings.kt index 4af73f34d..3a815f3bc 100644 --- a/app/src/main/java/com/github/libretube/preferences/MainSettings.kt +++ b/app/src/main/java/com/github/libretube/preferences/MainSettings.kt @@ -56,6 +56,15 @@ class MainSettings : PreferenceFragmentCompat() { true } + val player = findPreference("player") + player?.setOnPreferenceClickListener { + val newFragment = PlayerSettings() + navigateSettings(newFragment) + true + } + + + val advanced = findPreference("advanced") advanced?.setOnPreferenceClickListener { val newFragment = AdvancedSettings() diff --git a/app/src/main/java/com/github/libretube/preferences/PlayerSettings.kt b/app/src/main/java/com/github/libretube/preferences/PlayerSettings.kt new file mode 100644 index 000000000..84ed41c11 --- /dev/null +++ b/app/src/main/java/com/github/libretube/preferences/PlayerSettings.kt @@ -0,0 +1,17 @@ +package com.github.libretube.preferences + +import android.os.Bundle +import android.widget.TextView +import androidx.preference.PreferenceFragmentCompat +import com.github.libretube.R + +class PlayerSettings : PreferenceFragmentCompat() { + val TAG = "PlayerSettings" + + override fun onCreatePreferences(savedInstanceState: Bundle?, rootKey: String?) { + setPreferencesFromResource(R.xml.player_settings, rootKey) + + val topBarTextView = activity?.findViewById(R.id.topBar_textView) + topBarTextView?.text = getString(R.string.player) + } +} diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 8c4d8aaac..527a7ca25 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -143,9 +143,9 @@ You are running the latest version. Default playback speed Advanced - Player + Audio and video Adjust the app to your liking. - Player, downloads, history + Downloads, history Live This comment has no replies. Authors @@ -192,4 +192,7 @@ Autoplay Hide trending page URL to instance frontend + Quality + Behavior + Quality and player behavior diff --git a/app/src/main/res/xml/advanced_settings.xml b/app/src/main/res/xml/advanced_settings.xml index ff1be3d40..876626442 100644 --- a/app/src/main/res/xml/advanced_settings.xml +++ b/app/src/main/res/xml/advanced_settings.xml @@ -2,53 +2,6 @@ - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/xml/settings.xml b/app/src/main/res/xml/settings.xml index faea3f551..ac8704459 100644 --- a/app/src/main/res/xml/settings.xml +++ b/app/src/main/res/xml/settings.xml @@ -44,6 +44,12 @@ app:summary="@string/sponsorblock_summary" app:title="@string/sponsorblock" /> + +