From e2ee77674bdc458da03f250ac4955aaa3d565d02 Mon Sep 17 00:00:00 2001
From: Isira Seneviratne <isirasen96@gmail.com>
Date: Sat, 9 Sep 2023 06:41:32 +0530
Subject: [PATCH] refactor: Improve getSerializable extensions

---
 .../java/com/github/libretube/extensions/Bundle.kt    | 11 ++++++++---
 .../java/com/github/libretube/extensions/Intent.kt    |  7 +------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/src/main/java/com/github/libretube/extensions/Bundle.kt b/app/src/main/java/com/github/libretube/extensions/Bundle.kt
index 52ca984c2..e5da96054 100644
--- a/app/src/main/java/com/github/libretube/extensions/Bundle.kt
+++ b/app/src/main/java/com/github/libretube/extensions/Bundle.kt
@@ -5,16 +5,21 @@ import android.os.Bundle
 import android.os.Parcelable
 import androidx.core.os.BundleCompat
 import java.io.Serializable
+import kotlin.reflect.safeCast
 
 inline fun <reified T : Parcelable> Bundle.parcelable(key: String?): T? {
     return BundleCompat.getParcelable(this, key, T::class.java)
 }
 
-inline fun <reified T : Serializable> Bundle.serializable(key: String): T? {
+inline fun <reified T : Serializable> Bundle.serializable(key: String?): T? {
+    return getSerializable(this, key, T::class.java)
+}
+
+fun <T : Serializable> getSerializable(bundle: Bundle, key: String?, clazz: Class<T>): T? {
     return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
-        getSerializable(key, T::class.java)
+        bundle.getSerializable(key, clazz)
     } else {
         @Suppress("DEPRECATION")
-        getSerializable(key) as? T
+        clazz.kotlin.safeCast(bundle.getSerializable(key))
     }
 }
diff --git a/app/src/main/java/com/github/libretube/extensions/Intent.kt b/app/src/main/java/com/github/libretube/extensions/Intent.kt
index b2b3011e8..dfc8f4813 100644
--- a/app/src/main/java/com/github/libretube/extensions/Intent.kt
+++ b/app/src/main/java/com/github/libretube/extensions/Intent.kt
@@ -11,10 +11,5 @@ inline fun <reified T : Parcelable> Intent.parcelableExtra(name: String?): T? {
 }
 
 inline fun <reified T : Serializable> Intent.serializableExtra(name: String?): T? {
-    return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
-        getSerializableExtra(name, T::class.java)
-    } else {
-        @Suppress("DEPRECATION")
-        getSerializableExtra(name) as? T
-    }
+    return extras?.serializable(name)
 }