diff --git a/app/src/main/java/com/github/libretube/ui/dialogs/ShareDialog.kt b/app/src/main/java/com/github/libretube/ui/dialogs/ShareDialog.kt index dbd9d9e28..4c1cbf3fb 100644 --- a/app/src/main/java/com/github/libretube/ui/dialogs/ShareDialog.kt +++ b/app/src/main/java/com/github/libretube/ui/dialogs/ShareDialog.kt @@ -3,6 +3,7 @@ package com.github.libretube.ui.dialogs import android.app.Dialog import android.content.Intent import android.os.Bundle +import android.view.View import androidx.fragment.app.DialogFragment import com.github.libretube.R import com.github.libretube.constants.PIPED_FRONTEND_URL @@ -33,11 +34,7 @@ class ShareDialog( if (instanceUrl != "") shareOptions += getString(R.string.instance) if (shareObjectType == ShareObjectType.VIDEO && position != null) { - binding = DialogShareBinding.inflate(layoutInflater) - binding?.timeCodeSwitch?.isChecked = PreferenceHelper.getBoolean( - PreferenceKeys.SHARE_WITH_TIME_CODE, - true - ) + setupTimeStampBinding() } return MaterialAlertDialogBuilder(requireContext()) @@ -59,7 +56,7 @@ class ShareDialog( var url = "$host$path" if (shareObjectType == ShareObjectType.VIDEO && binding!!.timeCodeSwitch.isChecked) { - url += "&t=$position" + url += "&t=${binding!!.timeStamp.text}" } val intent = Intent() @@ -76,6 +73,19 @@ class ShareDialog( .show() } + private fun setupTimeStampBinding() { + binding = DialogShareBinding.inflate(layoutInflater) + binding!!.timeCodeSwitch.isChecked = PreferenceHelper.getBoolean( + PreferenceKeys.SHARE_WITH_TIME_CODE, + true + ) + binding!!.timeCodeSwitch.setOnCheckedChangeListener { _, isChecked -> + binding!!.timeStampLayout.visibility = if (isChecked) View.VISIBLE else View.GONE + } + binding!!.timeStamp.setText(position.toString()) + if (binding!!.timeCodeSwitch.isChecked) binding!!.timeStampLayout.visibility = View.VISIBLE + } + // get the frontend url if it's a custom instance private fun getCustomInstanceFrontendUrl(): String { val instancePref = PreferenceHelper.getString( diff --git a/app/src/main/res/layout/dialog_share.xml b/app/src/main/res/layout/dialog_share.xml index 8c4fd43ed..888901e31 100644 --- a/app/src/main/res/layout/dialog_share.xml +++ b/app/src/main/res/layout/dialog_share.xml @@ -1,15 +1,14 @@ - + android:orientation="vertical"> @@ -28,4 +27,22 @@ - \ No newline at end of file + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 01f25c24f..0645c336d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -346,6 +346,7 @@ Recently updated Recently updated (reversed) Show more + Time code Download Service