kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2025-04-28 16:00:31 +05:30
Code Issues Projects Releases Wiki Activity

Fixes: Labels under icons are not visible (#3066)

Browse Source 
* Made improvement to player double-tap further.

* Minor fixes.

* fix ktlint

* Filter out null comments returned from Piped API.

* Fixes: Labels under icons are not visible

* Minor player controls UI improvements

---------

Co-authored-by: Bnyro <bnyro@tutanota.com>
This commit is contained in:
Faisal Khan 2023-02-14 16:05:24 +05:30 committed by GitHub
parent 71c7af18df
commit c199d35913
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 75 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
app/release/output-metadata.json
View File

@ -11,49 +11,10 @@
"type": "UNIVERSAL", "type": "UNIVERSAL",
"filters": [], "filters": [],
"attributes": [], "attributes": [],
"versionCode": 26, "versionCode": 29,
"versionName": "0.10.0", "versionName": "0.12.0",
"outputFile": "app-universal-release.apk" "outputFile": "app-universal-release.apk"
}, },
{
"type": "ONE_OF_MANY",
"filters": [
{
"filterType": "ABI",
"value": "arm64-v8a"
}
],
"attributes": [],
"versionCode": 26,
"versionName": "0.10.0",
"outputFile": "app-arm64-v8a-release.apk"
},
{
"type": "ONE_OF_MANY",
"filters": [
{
"filterType": "ABI",
"value": "x86_64"
}
],
"attributes": [],
"versionCode": 26,
"versionName": "0.10.0",
"outputFile": "app-x86_64-release.apk"
},
{
"type": "ONE_OF_MANY",
"filters": [
{
"filterType": "ABI",
"value": "armeabi-v7a"
}
],
"attributes": [],
"versionCode": 26,
"versionName": "0.10.0",
"outputFile": "app-armeabi-v7a-release.apk"
},
{ {
"type": "ONE_OF_MANY", "type": "ONE_OF_MANY",
"filters": [ "filters": [
@ -63,9 +24,48 @@
} }
], ],
"attributes": [], "attributes": [],
"versionCode": 26, "versionCode": 29,
"versionName": "0.10.0", "versionName": "0.12.0",
"outputFile": "app-x86-release.apk" "outputFile": "app-x86-release.apk"
},
{
"type": "ONE_OF_MANY",
"filters": [
{
"filterType": "ABI",
"value": "armeabi-v7a"
}
],
"attributes": [],
"versionCode": 29,
"versionName": "0.12.0",
"outputFile": "app-armeabi-v7a-release.apk"
},
{
"type": "ONE_OF_MANY",
"filters": [
{
"filterType": "ABI",
"value": "x86_64"
}
],
"attributes": [],
"versionCode": 29,
"versionName": "0.12.0",
"outputFile": "app-x86_64-release.apk"
},
{
"type": "ONE_OF_MANY",
"filters": [
{
"filterType": "ABI",
"value": "arm64-v8a"
}
],
"attributes": [],
"versionCode": 29,
"versionName": "0.12.0",
"outputFile": "app-arm64-v8a-release.apk"
} }
], ],
"elementType": "File" "elementType": "File"

4
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt
View File

@ -1419,6 +1419,10 @@ class PlayerFragment : Fragment(R.layout.fragment_player), OnlinePlayerOptions {
binding.linLayout.visibility = View.VISIBLE binding.linLayout.visibility = View.VISIBLE
updateCaptionsLanguage(captionLanguage) updateCaptionsLanguage(captionLanguage)
binding.optionsLL.post {
binding.optionsLL.requestLayout()
}
} }
} }

12
app/src/main/res/drawable/ic_download.xml
View File

@ -2,9 +2,13 @@
android:width="24dp" android:width="24dp"
android:height="24dp" android:height="24dp"
android:tint="?attr/colorControlNormal" android:tint="?attr/colorControlNormal"
android:viewportWidth="48" android:viewportWidth="24"
android:viewportHeight="48"> android:viewportHeight="24">
<path <path
android:fillColor="#FF000000" android:pathData="M16,11L12,15M12,15L8,11M12,15L12,3M21,15L21,17C21,18.105 20.105,19 19,19L5,19C3.895,19 3,18.105 3,17L3,15"
android:pathData="M24,32.1 L13.9,22.05 16.35,19.6 22.3,25.55V7.15H25.7V25.55L31.65,19.6L34.1,22.05ZM10.8,40.55Q9.45,40.55 8.425,39.55Q7.4,38.55 7.4,37.15V29.45H10.8V37.15Q10.8,37.15 10.8,37.15Q10.8,37.15 10.8,37.15H37.15Q37.15,37.15 37.15,37.15Q37.15,37.15 37.15,37.15V29.45H40.55V37.15Q40.55,38.55 39.55,39.55Q38.55,40.55 37.15,40.55Z" /> android:strokeLineJoin="round"
android:strokeWidth="2"
android:fillColor="#00000000"
android:strokeColor="#000000"
android:strokeLineCap="round"/>
</vector> </vector>

19
app/src/main/res/layout/fragment_player.xml
View File

@ -128,8 +128,9 @@
<com.google.android.material.card.MaterialCardView <com.google.android.material.card.MaterialCardView
style="@style/Widget.Material3.CardView.Elevated" style="@style/Widget.Material3.CardView.Elevated"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="80dp" android:layout_height="wrap_content"
android:layout_margin="17dp" android:layout_marginHorizontal="10dp"
android:layout_marginVertical="17dp"
app:cardCornerRadius="27dp"> app:cardCornerRadius="27dp">
<LinearLayout <LinearLayout
@ -137,36 +138,36 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="center" android:layout_gravity="center"
android:layout_marginLeft="10dp" android:layout_marginHorizontal="8dp"
android:layout_marginRight="10dp" android:layout_marginVertical="18dp"
android:gravity="center" android:gravity="center"
android:orientation="horizontal"> android:orientation="horizontal">
<TextView <com.github.libretube.ui.views.DrawableTextView
android:id="@+id/relPlayer_share" android:id="@+id/relPlayer_share"
style="@style/PlayerActionsText" style="@style/PlayerActionsText"
android:text="@string/share" android:text="@string/share"
app:drawableTopCompat="@drawable/ic_share" /> app:drawableTopCompat="@drawable/ic_share" />
<TextView <com.github.libretube.ui.views.DrawableTextView
android:id="@+id/relPlayer_download" android:id="@+id/relPlayer_download"
style="@style/PlayerActionsText" style="@style/PlayerActionsText"
android:text="@string/download" android:text="@string/download"
app:drawableTopCompat="@drawable/ic_download" /> app:drawableTopCompat="@drawable/ic_download" />
<TextView <com.github.libretube.ui.views.DrawableTextView
android:id="@+id/relPlayer_pip" android:id="@+id/relPlayer_pip"
style="@style/PlayerActionsText" style="@style/PlayerActionsText"
android:text="@string/pop_up" android:text="@string/pop_up"
app:drawableTopCompat="@drawable/ic_open" /> app:drawableTopCompat="@drawable/ic_open" />
<TextView <com.github.libretube.ui.views.DrawableTextView
android:id="@+id/relPlayer_background" android:id="@+id/relPlayer_background"
style="@style/PlayerActionsText" style="@style/PlayerActionsText"
android:text="@string/audio" android:text="@string/audio"
app:drawableTopCompat="@drawable/ic_headphones" /> app:drawableTopCompat="@drawable/ic_headphones" />
<TextView <com.github.libretube.ui.views.DrawableTextView
android:id="@+id/relPlayer_save" android:id="@+id/relPlayer_save"
style="@style/PlayerActionsText" style="@style/PlayerActionsText"
android:text="@string/save" android:text="@string/save"

14
app/src/main/res/values/style.xml
View File

@ -76,18 +76,22 @@
</style> </style>
<style name="PlayerActionsText"> <style name="PlayerActionsText">
<item name="android:autoSizeTextType" tools:targetApi="o">uniform</item> <item name="android:autoSizeTextType" tools:targetApi="o">uniform</item>
<item name="android:autoSizeMinTextSize" tools:targetApi="o">10sp</item> <item name="android:autoSizeMinTextSize" tools:targetApi="o">10sp</item>
<item name="android:textSize">16sp</item> <item name="android:autoSizeMaxTextSize" tools:targetApi="p">14sp</item>
<item name="android:autoSizeMaxTextSize" tools:targetApi="p">16sp</item> <item name="android:textSize">14sp</item>
<item name="android:maxLines">1</item> <item name="android:maxLines">1</item>
<item name="android:gravity">bottom</item> <item name="android:gravity">center</item>
<item name="android:textAlignment">center</item>
<item name="android:background">?attr/selectableItemBackgroundBorderless</item> <item name="android:background">?attr/selectableItemBackgroundBorderless</item>
<item name="android:layout_gravity">bottom</item>
<item name="android:layout_width">0dp</item> <item name="android:layout_width">0dp</item>
<item name="android:layout_height">wrap_content</item> <item name="android:layout_height">wrap_content</item>
<item name="android:layout_weight">1</item> <item name="android:layout_weight">1</item>
<item name="android:layout_marginStart">3dp</item>
<item name="android:layout_marginEnd">3dp</item>
<item name="drawableTopDimen">24dp</item>
<item name="android:drawablePadding">3dp</item>
</style> </style>
<style name="PlayerControlBottom"> <style name="PlayerControlBottom">