From bf33dcd0544bd068994c71e72f44f7c7123523da Mon Sep 17 00:00:00 2001 From: Bnyro Date: Fri, 14 Jun 2024 19:34:58 +0200 Subject: [PATCH] ci: drop ktlint --- .github/workflows/lint.yml | 19 ------------------- README.md | 3 +-- 2 files changed, 1 insertion(+), 21 deletions(-) delete mode 100644 .github/workflows/lint.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml deleted file mode 100644 index afb0af4b2..000000000 --- a/.github/workflows/lint.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: reviewdog -on: [pull_request] -permissions: write-all -jobs: - ktlint: - name: Check Code Quality - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 1 - - name: ktlint - uses: ScaCap/action-ktlint@v1.8.3 - with: - github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-check - android: true - fail_on_error: true diff --git a/README.md b/README.md index 956f968db..513d2df23 100644 --- a/README.md +++ b/README.md @@ -106,10 +106,9 @@ Contributing Whether you have ideas, translations, design changes, code cleaning or really heavy code changes, help is always welcome. The more is done, the better it gets! Please respect our [Code of Conduct](https://github.com/libre-tube/LibreTube/blob/master/CODE_OF_CONDUCT.md) in order to keep all interactions and dicussions healthy. You can open and build the project like any other normal Android project by using Android Studio. -If creating a pull request containing code changes, please make sure to format your code with `ktlint --code-style=android_studio -F` before. Please make sure the title of your pull request and the commit messages follow the [conventional commit types](https://github.com/commitizen/conventional-commit-types/blob/master/index.json) (e.g. `feat: support for xy`). -The most common commit types are "feat", "fix", "refactor", "ci" and "chore". +For instance, the most common commit types are "feat", "fix", "refactor", "ci" and "chore". > **Note**
> Any issue avoiding the issue template will be ignored and forced to be closed.