kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2024-12-14 22:30:30 +05:30
Code Issues Projects Releases Wiki Activity

Merge pull request #4544 from Bnyro/master

Browse Source 
fix: remove useless buttons to reset pitch and playback speed
This commit is contained in:
Bnyro 2023-08-19 10:30:29 +02:00 committed by GitHub
commit b45793877a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/java/com/github/libretube/ui/sheets/PlaybackOptionsSheet.kt
View File

@ -10,7 +10,6 @@ import androidx.recyclerview.widget.GridLayoutManager
import com.github.libretube.constants.PreferenceKeys import com.github.libretube.constants.PreferenceKeys
import com.github.libretube.databinding.PlaybackBottomSheetBinding import com.github.libretube.databinding.PlaybackBottomSheetBinding
import com.github.libretube.extensions.round import com.github.libretube.extensions.round
import com.github.libretube.helpers.PlayerHelper
import com.github.libretube.helpers.PreferenceHelper import com.github.libretube.helpers.PreferenceHelper
import com.github.libretube.ui.adapters.SliderLabelsAdapter import com.github.libretube.ui.adapters.SliderLabelsAdapter
@ -55,15 +54,6 @@ class PlaybackOptionsSheet(
onChange() onChange()
} }
binding.resetSpeed.setOnClickListener {
binding.speed.value = PlayerHelper.playbackSpeed
}
binding.resetPitch.setOnClickListener {
binding.pitch.value = 1f
onChange()
}
binding.skipSilence.setOnCheckedChangeListener { _, isChecked -> binding.skipSilence.setOnCheckedChangeListener { _, isChecked ->
player.skipSilenceEnabled = isChecked player.skipSilenceEnabled = isChecked
PreferenceHelper.putBoolean(PreferenceKeys.SKIP_SILENCE, isChecked) PreferenceHelper.putBoolean(PreferenceKeys.SKIP_SILENCE, isChecked)

39
app/src/main/res/layout/playback_bottom_sheet.xml
View File

@ -41,32 +41,15 @@
android:layout_marginTop="10dp" android:layout_marginTop="10dp"
android:orientation="horizontal" /> android:orientation="horizontal" />
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content">
<com.google.android.material.slider.Slider <com.google.android.material.slider.Slider
android:id="@+id/speed" android:id="@+id/speed"
android:layout_width="0dp" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="1"
android:stepSize="0.1" android:stepSize="0.1"
android:value="1.0" android:value="1.0"
android:valueFrom="0.2" android:valueFrom="0.2"
android:valueTo="4.0" /> android:valueTo="4.0" />
<ImageView
android:id="@+id/reset_speed"
android:tooltipText="@string/reset"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:layout_marginStart="5dp"
android:background="?attr/selectableItemBackgroundBorderless"
android:src="@drawable/ic_history" />
</LinearLayout>
<TextView <TextView
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
@ -79,33 +62,15 @@
android:layout_marginTop="10dp" android:layout_marginTop="10dp"
android:orientation="horizontal" /> android:orientation="horizontal" />
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal">
<com.google.android.material.slider.Slider <com.google.android.material.slider.Slider
android:id="@+id/pitch" android:id="@+id/pitch"
android:layout_width="0dp" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="1"
android:stepSize="0.1" android:stepSize="0.1"
android:value="1.0" android:value="1.0"
android:valueFrom="0.5" android:valueFrom="0.5"
android:valueTo="2.0" /> android:valueTo="2.0" />
<ImageView
android:id="@+id/reset_pitch"
android:tooltipText="@string/reset"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:layout_marginStart="5dp"
android:background="?attr/selectableItemBackgroundBorderless"
android:src="@drawable/ic_history" />
</LinearLayout>
</LinearLayout> </LinearLayout>
<com.google.android.material.checkbox.MaterialCheckBox <com.google.android.material.checkbox.MaterialCheckBox