kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2025-04-28 16:00:31 +05:30
Code Issues Projects Releases Wiki Activity

Do not stat pip when open video externally

Browse Source 
When opening a video in an external player picture in picture should
not be started.
This commit is contained in:
Erzock 2022-09-30 20:58:13 +02:00
parent 002a9a5f8a
commit adc7fc6fd3
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt
View File

@ -166,6 +166,7 @@ class PlayerFragment : BaseFragment() {
private var sponsorBlockNotifications = true private var sponsorBlockNotifications = true
private var skipButtonsEnabled = false private var skipButtonsEnabled = false
private var pipEnabled = true private var pipEnabled = true
private var videoShownInExternalPlayer = false
private var skipSegmentsManually = false private var skipSegmentsManually = false
/** /**
@ -664,6 +665,13 @@ class PlayerFragment : BaseFragment() {
if (!commentsLoaded!!) fetchComments() if (!commentsLoaded!!) fetchComments()
} }
override fun onStart() {
super.onStart()
// Assuming the video is not playing in external player when returning to app
videoShownInExternalPlayer = false
}
override fun onPause() { override fun onPause() {
// pauses the player if the screen is turned off // pauses the player if the screen is turned off
@ -1047,6 +1055,9 @@ class PlayerFragment : BaseFragment() {
if (response.hls != null) { if (response.hls != null) {
binding.relPlayerOpen.setOnClickListener { binding.relPlayerOpen.setOnClickListener {
// Do not start picture in picture when playing in external player
videoShownInExternalPlayer = true
// start an intent with video as mimetype using the hls stream // start an intent with video as mimetype using the hls stream
val uri: Uri = Uri.parse(response.hls) val uri: Uri = Uri.parse(response.hls)
val intent = Intent() val intent = Intent()
@ -1504,7 +1515,11 @@ class PlayerFragment : BaseFragment() {
} }
private fun shouldStartPiP(): Boolean { private fun shouldStartPiP(): Boolean {
if (!pipEnabled || exoPlayer.playbackState == PlaybackState.STATE_PAUSED) return false if (!pipEnabled ||
exoPlayer.playbackState == PlaybackState.STATE_PAUSED ||
videoShownInExternalPlayer) {
return false
}
val bounds = Rect() val bounds = Rect()
binding.playerScrollView.getHitRect(bounds) binding.playerScrollView.getHitRect(bounds)