From a5d41b780283613de9f2341d2035215fdf1f19bc Mon Sep 17 00:00:00 2001 From: Bnyro Date: Fri, 17 Nov 2023 14:57:35 +0100 Subject: [PATCH] fix: crash when trying to vote while there are no sb segments yet --- .../github/libretube/ui/dialogs/VoteForSegmentDialog.kt | 7 +++++++ app/src/main/res/values/strings.xml | 1 + 2 files changed, 8 insertions(+) diff --git a/app/src/main/java/com/github/libretube/ui/dialogs/VoteForSegmentDialog.kt b/app/src/main/java/com/github/libretube/ui/dialogs/VoteForSegmentDialog.kt index 17d0b0e1a..4e5ad6acc 100644 --- a/app/src/main/java/com/github/libretube/ui/dialogs/VoteForSegmentDialog.kt +++ b/app/src/main/java/com/github/libretube/ui/dialogs/VoteForSegmentDialog.kt @@ -6,6 +6,7 @@ import android.os.Bundle import android.text.format.DateUtils import android.util.Log import android.widget.ArrayAdapter +import android.widget.Toast import androidx.fragment.app.DialogFragment import androidx.lifecycle.lifecycleScope import com.github.libretube.R @@ -92,6 +93,12 @@ class VoteForSegmentDialog : DialogFragment() { withContext(Dispatchers.Main) { val binding = _binding ?: return@withContext + if (segments.isEmpty()) { + dismiss() + Toast.makeText(context, R.string.no_segments_found, Toast.LENGTH_SHORT).show() + return@withContext + } + val segmentTexts = segments.map { "${it.category} (${ DateUtils.formatElapsedTime(it.segmentStartAndEnd.first.toLong()) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 21fbd67b0..4d2d67cd0 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -494,6 +494,7 @@ Remember playback speed Successfully removed \"%1$s\" from the playlist. Watched + There are no segments for this video yet. Download Service