kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2025-04-29 16:30:31 +05:30
Code Issues Projects Releases Wiki Activity

Merge pull request #5379 from Isira-Seneviratne/ClipboardHelper

Browse Source 
refactor: Improve ClipboardHelper
This commit is contained in:
Isira Seneviratne 2023-12-23 15:13:05 +05:30 committed by GitHub
commit 8f13d13084
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/com/github/libretube/helpers/ClipboardHelper.kt
View File

@ -7,8 +7,8 @@ import androidx.core.content.getSystemService
import com.github.libretube.R import com.github.libretube.R
object ClipboardHelper { object ClipboardHelper {
fun save(context: Context, text: String) { fun save(context: Context, label: String = context.getString(R.string.copied), text: String) {
val clip = ClipData.newPlainText(context.getString(R.string.copied), text) val clip = ClipData.newPlainText(label, text)
context.getSystemService<ClipboardManager>()!!.setPrimaryClip(clip) context.getSystemService<ClipboardManager>()!!.setPrimaryClip(clip)
} }
} }

2
app/src/main/java/com/github/libretube/ui/activities/AboutActivity.kt
View File

@ -65,7 +65,7 @@ class AboutActivity : BaseActivity() {
private fun onLongClick(href: String) { private fun onLongClick(href: String) {
// copy the link to the clipboard // copy the link to the clipboard
ClipboardHelper.save(this, href) ClipboardHelper.save(this, text = href)
// show the snackBar with open action // show the snackBar with open action
Snackbar.make( Snackbar.make(
binding.root, binding.root,

2
app/src/main/java/com/github/libretube/ui/adapters/CommentsAdapter.kt
View File

@ -136,7 +136,7 @@ class CommentsAdapter(
root.setOnLongClickListener { root.setOnLongClickListener {
ClipboardHelper.save( ClipboardHelper.save(
root.context, root.context,
comment.commentText.orEmpty().parseAsHtml().toString() text = comment.commentText.orEmpty().parseAsHtml().toString()
) )
Toast.makeText(root.context, R.string.copied, Toast.LENGTH_SHORT).show() Toast.makeText(root.context, R.string.copied, Toast.LENGTH_SHORT).show()
true true

2
app/src/main/java/com/github/libretube/ui/dialogs/ErrorDialog.kt
View File

@ -22,7 +22,7 @@ class ErrorDialog : DialogFragment() {
.setMessage(errorLog) .setMessage(errorLog)
.setNegativeButton(R.string.okay, null) .setNegativeButton(R.string.okay, null)
.setPositiveButton(androidx.preference.R.string.copy) { _, _ -> .setPositiveButton(androidx.preference.R.string.copy) { _, _ ->
ClipboardHelper.save(requireContext(), errorLog) ClipboardHelper.save(requireContext(), text = errorLog)
Toast.makeText(context, R.string.copied, Toast.LENGTH_SHORT).show() Toast.makeText(context, R.string.copied, Toast.LENGTH_SHORT).show()
} }
.show() .show()

17
app/src/main/java/com/github/libretube/ui/sheets/StatsSheet.kt
View File

@ -1,19 +1,13 @@
package com.github.libretube.ui.sheets package com.github.libretube.ui.sheets
import android.annotation.SuppressLint
import android.content.ClipData
import android.content.ClipboardManager
import android.content.Context
import android.os.Build
import android.os.Bundle import android.os.Bundle
import android.view.LayoutInflater import android.view.LayoutInflater
import android.view.View import android.view.View
import android.view.ViewGroup import android.view.ViewGroup
import androidx.core.content.ContextCompat.getSystemService
import androidx.core.content.getSystemService
import com.github.libretube.constants.IntentData import com.github.libretube.constants.IntentData
import com.github.libretube.databinding.DialogStatsBinding import com.github.libretube.databinding.DialogStatsBinding
import com.github.libretube.extensions.parcelable import com.github.libretube.extensions.parcelable
import com.github.libretube.helpers.ClipboardHelper
import com.github.libretube.obj.VideoStats import com.github.libretube.obj.VideoStats
class StatsSheet : ExpandedBottomSheet() { class StatsSheet : ExpandedBottomSheet() {
@ -35,19 +29,12 @@ class StatsSheet : ExpandedBottomSheet() {
stats = arguments?.parcelable(IntentData.videoStats)!! stats = arguments?.parcelable(IntentData.videoStats)!!
} }
@SuppressLint("SetTextI18n")
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
val binding = binding val binding = binding
val clipboardManager = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
context?.getSystemService(ClipboardManager::class.java)!!
} else {
context?.getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager
}
binding.videoId.setText(stats.videoId) binding.videoId.setText(stats.videoId)
binding.videoIdCopy.setEndIconOnClickListener { binding.videoIdCopy.setEndIconOnClickListener {
clipboardManager.setPrimaryClip(ClipData.newPlainText("text", stats.videoId)) ClipboardHelper.save(requireContext(), "text", stats.videoId)
} }
binding.videoInfo.setText(stats.videoInfo) binding.videoInfo.setText(stats.videoInfo)
binding.audioInfo.setText(stats.audioInfo) binding.audioInfo.setText(stats.audioInfo)