From 7f9c3451ff2f6921650b15634d5ac4800e8b7c20 Mon Sep 17 00:00:00 2001 From: zechs Date: Tue, 14 Jun 2022 21:29:02 +0530 Subject: [PATCH 1/5] Wrapped thumbnail-duration text in a CardView --- app/src/main/res/layout/trending_row.xml | 48 +++++++++++++++--------- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/app/src/main/res/layout/trending_row.xml b/app/src/main/res/layout/trending_row.xml index 72260e2ed..039bf4c63 100644 --- a/app/src/main/res/layout/trending_row.xml +++ b/app/src/main/res/layout/trending_row.xml @@ -1,10 +1,10 @@ + android:layout_height="wrap_content" + android:background="?android:attr/selectableItemBackground"> + app:layout_constraintTop_toTopOf="parent"> + android:layout_height="match_parent" + android:src="@mipmap/ic_launcher" /> - + app:cardBackgroundColor="@color/duration_background_color" + app:cardCornerRadius="8dp"> + + + + + @@ -45,24 +57,24 @@ android:layout_marginStart="8dp" android:layout_marginTop="8dp" android:layout_marginEnd="8dp" + android:ellipsize="end" + android:maxLines="2" android:text="Title" android:textSize="15sp" android:textStyle="bold" app:layout_constraintEnd_toEndOf="@+id/thumbnailcard" app:layout_constraintStart_toEndOf="@+id/channel_image" - app:layout_constraintTop_toBottomOf="@+id/thumbnailcard" - android:ellipsize="end" - android:maxLines="2" /> + app:layout_constraintTop_toBottomOf="@+id/thumbnailcard" /> + app:layout_constraintTop_toBottomOf="@+id/textView_title" /> Date: Wed, 15 Jun 2022 11:36:13 +0530 Subject: [PATCH 2/5] Wrapped search-thumbnail-duration text in a CardView --- app/src/main/res/layout/video_search_row.xml | 44 +++++++++++++------- 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/app/src/main/res/layout/video_search_row.xml b/app/src/main/res/layout/video_search_row.xml index 84eb2cf8d..a8ca7ed9d 100644 --- a/app/src/main/res/layout/video_search_row.xml +++ b/app/src/main/res/layout/video_search_row.xml @@ -2,11 +2,11 @@ + android:background="?android:attr/selectableItemBackground"> + app:strokeWidth="0dp"> - + app:cardBackgroundColor="@color/duration_background_color" + app:cardCornerRadius="8dp"> + + + + + @@ -83,9 +95,9 @@ android:layout_height="wrap_content" android:layout_marginStart="8dp" android:layout_marginTop="12dp" - app:layout_constraintEnd_toEndOf="parent" - android:maxLines="1" android:ellipsize="end" + android:maxLines="1" + app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@+id/search_channel_image" app:layout_constraintTop_toBottomOf="@+id/search_views" /> From d55446099147fad43b22becd25662a0aa3e2043d Mon Sep 17 00:00:00 2001 From: zechs Date: Wed, 15 Jun 2022 11:37:19 +0530 Subject: [PATCH 3/5] Wrapped channel-duration text in a CardView --- app/src/main/res/layout/video_channel_row.xml | 32 +++++++++++++------ 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/app/src/main/res/layout/video_channel_row.xml b/app/src/main/res/layout/video_channel_row.xml index 6536befd9..df801ad78 100644 --- a/app/src/main/res/layout/video_channel_row.xml +++ b/app/src/main/res/layout/video_channel_row.xml @@ -2,11 +2,11 @@ + android:background="?android:attr/selectableItemBackground"> + app:strokeWidth="0dp"> - + app:cardBackgroundColor="@color/duration_background_color" + app:cardCornerRadius="8dp"> + + + + + Date: Wed, 15 Jun 2022 11:40:39 +0530 Subject: [PATCH 4/5] Wrapped playlist-duration text in a CardView --- app/src/main/res/layout/playlist_row.xml | 41 +++++++++++++++--------- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/app/src/main/res/layout/playlist_row.xml b/app/src/main/res/layout/playlist_row.xml index b0c4e6095..ef75d4508 100644 --- a/app/src/main/res/layout/playlist_row.xml +++ b/app/src/main/res/layout/playlist_row.xml @@ -2,12 +2,12 @@ + android:background="?android:attr/selectableItemBackground"> + app:strokeWidth="0dp"> - + app:cardBackgroundColor="@color/duration_background_color" + app:cardCornerRadius="8dp"> + + + + + android:src="@drawable/ic_delete" + android:visibility="gone" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintTop_toTopOf="parent" + app:shapeAppearanceOverlay="@style/roundedImageViewRounded" /> \ No newline at end of file From 3f78c94ab7f76aabcda91a59d6c3689a001330f3 Mon Sep 17 00:00:00 2001 From: zechs Date: Wed, 15 Jun 2022 11:45:52 +0530 Subject: [PATCH 5/5] Fix: Two-tone color due to card elevation --- app/src/main/res/layout/playlist_row.xml | 3 ++- app/src/main/res/layout/trending_row.xml | 3 ++- app/src/main/res/layout/video_channel_row.xml | 3 ++- app/src/main/res/layout/video_search_row.xml | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/src/main/res/layout/playlist_row.xml b/app/src/main/res/layout/playlist_row.xml index ef75d4508..cca5c2238 100644 --- a/app/src/main/res/layout/playlist_row.xml +++ b/app/src/main/res/layout/playlist_row.xml @@ -42,7 +42,8 @@ android:layout_gravity="bottom|end" android:layout_margin="5dp" app:cardBackgroundColor="@color/duration_background_color" - app:cardCornerRadius="8dp"> + app:cardCornerRadius="8dp" + app:cardElevation="0dp"> + app:cardCornerRadius="8dp" + app:cardElevation="0dp"> + app:cardCornerRadius="8dp" + app:cardElevation="0dp"> + app:cardCornerRadius="8dp" + app:cardElevation="0dp">