kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2025-04-29 00:10:32 +05:30
Code Issues Projects Releases Wiki Activity

Merge pull request #5290 from Isira-Seneviratne/Binding_improvements

Browse Source 
refactor: Improve view binding
This commit is contained in:
Isira Seneviratne 2023-12-06 04:48:03 +05:30 committed by GitHub
commit 6ac50d22b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/com/github/libretube/ui/activities/HelpActivity.kt
View File

@ -7,12 +7,10 @@ import com.github.libretube.ui.base.BaseActivity
import com.google.android.material.card.MaterialCardView import com.google.android.material.card.MaterialCardView
class HelpActivity : BaseActivity() { class HelpActivity : BaseActivity() {
private lateinit var binding: ActivityHelpBinding
override fun onCreate(savedInstanceState: Bundle?) { override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState) super.onCreate(savedInstanceState)
binding = ActivityHelpBinding.inflate(layoutInflater) val binding = ActivityHelpBinding.inflate(layoutInflater)
setContentView(binding.root) setContentView(binding.root)
binding.toolbar.setNavigationOnClickListener { binding.toolbar.setNavigationOnClickListener {

4
app/src/main/java/com/github/libretube/ui/activities/NoInternetActivity.kt
View File

@ -14,12 +14,10 @@ import com.github.libretube.ui.fragments.DownloadsFragment
import com.google.android.material.snackbar.Snackbar import com.google.android.material.snackbar.Snackbar
class NoInternetActivity : BaseActivity() { class NoInternetActivity : BaseActivity() {
private lateinit var binding: ActivityNointernetBinding
override fun onCreate(savedInstanceState: Bundle?) { override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState) super.onCreate(savedInstanceState)
binding = ActivityNointernetBinding.inflate(layoutInflater) val binding = ActivityNointernetBinding.inflate(layoutInflater)
// retry button // retry button
binding.retryButton.setOnClickListener { binding.retryButton.setOnClickListener {
if (NetworkHelper.isNetworkAvailable(this)) { if (NetworkHelper.isNetworkAvailable(this)) {

7
app/src/main/java/com/github/libretube/ui/views/DoubleTapOverlay.kt
View File

@ -10,10 +10,5 @@ class DoubleTapOverlay(
context: Context, context: Context,
attrs: AttributeSet? = null attrs: AttributeSet? = null
) : LinearLayout(context, attrs) { ) : LinearLayout(context, attrs) {
var binding: DoubleTapOverlayBinding val binding = DoubleTapOverlayBinding.inflate(LayoutInflater.from(context), this, true)
init {
val layoutInflater = LayoutInflater.from(context)
binding = DoubleTapOverlayBinding.inflate(layoutInflater, this, true)
}
} }

12
app/src/main/java/com/github/libretube/ui/views/DropdownMenu.kt
View File

@ -15,7 +15,8 @@ class DropdownMenu(
context: Context, context: Context,
attributeSet: AttributeSet attributeSet: AttributeSet
) : FrameLayout(context, attributeSet) { ) : FrameLayout(context, attributeSet) {
var binding: DropdownMenuBinding private val binding =
DropdownMenuBinding.inflate(LayoutInflater.from(context), this, true)
@Suppress("UNCHECKED_CAST") @Suppress("UNCHECKED_CAST")
var adapter: ArrayAdapter<String> var adapter: ArrayAdapter<String>
@ -26,15 +27,10 @@ class DropdownMenu(
} }
val selectedItemPosition: Int val selectedItemPosition: Int
get() = adapter.getPosition( get() = adapter.getPosition(binding.autoCompleteTextView.text.toString())
binding.autoCompleteTextView.text.toString()
)
init { init {
val layoutInflater = LayoutInflater.from(context) val ta = context.obtainStyledAttributes(attributeSet, R.styleable.DropdownMenu, 0, 0)
binding = DropdownMenuBinding.inflate(layoutInflater, this, true)
val ta = getContext().obtainStyledAttributes(attributeSet, R.styleable.DropdownMenu, 0, 0)
try { try {
binding.textInputLayout.hint = ta.getString(R.styleable.DropdownMenu_hint) binding.textInputLayout.hint = ta.getString(R.styleable.DropdownMenu_hint)

7
app/src/main/java/com/github/libretube/ui/views/PlayerGestureControlsView.kt
View File

@ -11,12 +11,7 @@ class PlayerGestureControlsView(
context: Context, context: Context,
attrs: AttributeSet? = null attrs: AttributeSet? = null
) : ConstraintLayout(context, attrs) { ) : ConstraintLayout(context, attrs) {
var binding: PlayerGestureControlsViewBinding val binding = PlayerGestureControlsViewBinding.inflate(LayoutInflater.from(context), this, true)
init {
val layoutInflater = LayoutInflater.from(context)
binding = PlayerGestureControlsViewBinding.inflate(layoutInflater, this, true)
}
override fun onSizeChanged(width: Int, height: Int, oldWidth: Int, oldHeight: Int) { override fun onSizeChanged(width: Int, height: Int, oldWidth: Int, oldHeight: Int) {
super.onSizeChanged(width, height, oldHeight, oldHeight) super.onSizeChanged(width, height, oldHeight, oldHeight)