From 5eddd63ed3f2ad3d8da7b2f8aa7ca1eab9e3b100 Mon Sep 17 00:00:00 2001 From: Faisal Khan Date: Tue, 14 Feb 2023 20:05:07 +0530 Subject: [PATCH] Removes callbacks when player fragment is destroyed. (#3073) * Made improvement to player double-tap further. * Minor fixes. * fix ktlint * Filter out null comments returned from Piped API. * Fixes: Labels under icons are not visible * Minor player controls UI improvements * Removes callbacks when player fragment is destroyed. --------- Co-authored-by: Bnyro --- .../java/com/github/libretube/ui/fragments/PlayerFragment.kt | 3 +++ .../com/github/libretube/ui/sheets/ExpandedBottomSheet.kt | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt b/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt index a4c970a4c..a3d62ef3b 100644 --- a/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt +++ b/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt @@ -577,6 +577,9 @@ class PlayerFragment : Fragment(R.layout.fragment_player), OnlinePlayerOptions { override fun onDestroy() { super.onDestroy() + + handler.removeCallbacksAndMessages(null) + try { // disable the auto PiP mode for SDK >= 32 disableAutoPiP() diff --git a/app/src/main/java/com/github/libretube/ui/sheets/ExpandedBottomSheet.kt b/app/src/main/java/com/github/libretube/ui/sheets/ExpandedBottomSheet.kt index a1e2d6007..94b8959f0 100644 --- a/app/src/main/java/com/github/libretube/ui/sheets/ExpandedBottomSheet.kt +++ b/app/src/main/java/com/github/libretube/ui/sheets/ExpandedBottomSheet.kt @@ -19,8 +19,8 @@ open class ExpandedBottomSheet : BottomSheetDialogFragment() { dialog.setOnShowListener { (it as BottomSheetDialog).let { d -> - (d.findViewById(R.id.design_bottom_sheet) as FrameLayout?)?.let { - BottomSheetBehavior.from(it).state = + (d.findViewById(R.id.design_bottom_sheet) as FrameLayout?)?.let { fl -> + BottomSheetBehavior.from(fl).state = BottomSheetBehavior.STATE_EXPANDED } }