kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2024-12-13 13:50:30 +05:30
Code Issues Projects Releases Wiki Activity

Merge pull request #5405 from Bnyro/master

Browse Source 
fix: remove unnecessary subscription status api call in channel fragment
This commit is contained in:
Bnyro 2023-12-30 17:25:22 +01:00 committed by GitHub
commit 5bf65dfcfe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/com/github/libretube/ui/fragments/ChannelFragment.kt
View File

@ -14,12 +14,12 @@ import androidx.navigation.fragment.navArgs
import androidx.recyclerview.widget.GridLayoutManager import androidx.recyclerview.widget.GridLayoutManager
import com.github.libretube.R import com.github.libretube.R
import com.github.libretube.api.RetrofitInstance import com.github.libretube.api.RetrofitInstance
import com.github.libretube.api.SubscriptionHelper
import com.github.libretube.api.obj.ChannelTab import com.github.libretube.api.obj.ChannelTab
import com.github.libretube.constants.IntentData import com.github.libretube.constants.IntentData
import com.github.libretube.databinding.FragmentChannelBinding import com.github.libretube.databinding.FragmentChannelBinding
import com.github.libretube.enums.ShareObjectType import com.github.libretube.enums.ShareObjectType
import com.github.libretube.extensions.TAG import com.github.libretube.extensions.TAG
import com.github.libretube.extensions.ceilHalf
import com.github.libretube.extensions.formatShort import com.github.libretube.extensions.formatShort
import com.github.libretube.extensions.toID import com.github.libretube.extensions.toID
import com.github.libretube.helpers.ImageHelper import com.github.libretube.helpers.ImageHelper
@ -38,7 +38,6 @@ import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import retrofit2.HttpException import retrofit2.HttpException
import java.io.IOException import java.io.IOException
import kotlin.math.ceil
class ChannelFragment : DynamicLayoutManagerFragment() { class ChannelFragment : DynamicLayoutManagerFragment() {
private var _binding: FragmentChannelBinding? = null private var _binding: FragmentChannelBinding? = null
@ -49,7 +48,6 @@ class ChannelFragment : DynamicLayoutManagerFragment() {
private var channelName: String? = null private var channelName: String? = null
private var channelAdapter: VideosAdapter? = null private var channelAdapter: VideosAdapter? = null
private var isLoading = true private var isLoading = true
private var isSubscribed: Boolean? = false
private val possibleTabs = arrayOf( private val possibleTabs = arrayOf(
ChannelTabs.Shorts, ChannelTabs.Shorts,
@ -79,7 +77,7 @@ class ChannelFragment : DynamicLayoutManagerFragment() {
override fun setLayoutManagers(gridItems: Int) { override fun setLayoutManagers(gridItems: Int) {
_binding?.channelRecView?.layoutManager = GridLayoutManager( _binding?.channelRecView?.layoutManager = GridLayoutManager(
context, context,
ceil((gridItems.toDouble() / 2)).toInt() gridItems.ceilHalf()
) )
} }
@ -169,8 +167,6 @@ class ChannelFragment : DynamicLayoutManagerFragment() {
val shareData = ShareData(currentChannel = response.name) val shareData = ShareData(currentChannel = response.name)
val channelId = channelId ?: return@launch val channelId = channelId ?: return@launch
// fetch and update the subscription status
isSubscribed = SubscriptionHelper.isSubscribed(channelId) ?: false
binding.channelSubscribe.setupSubscriptionButton( binding.channelSubscribe.setupSubscriptionButton(
channelId, channelId,