kavin/LibreTube
1
0
Fork 0
mirror of https://github.com/libre-tube/LibreTube.git synced 2024-12-14 22:30:30 +05:30
Code Issues Projects Releases Wiki Activity

Fix crash in CommentsMainFragment

Browse Source
This commit is contained in:
Bnyro 2023-05-15 14:19:14 +02:00
parent 19390368e8
commit 5b6b1a3dfa
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/com/github/libretube/ui/fragments/CommentsMainFragment.kt
View File

@ -34,12 +34,13 @@ class CommentsMainFragment : Fragment() {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState) super.onViewCreated(view, savedInstanceState)
val binding = _binding ?: return
val layoutManager = LinearLayoutManager(requireContext()) val layoutManager = LinearLayoutManager(requireContext())
binding.commentsRV.layoutManager = layoutManager binding.commentsRV.layoutManager = layoutManager
binding.commentsRV.setItemViewCacheSize(20) binding.commentsRV.setItemViewCacheSize(20)
binding.commentsRV.viewTreeObserver.addOnScrollChangedListener { binding.commentsRV.viewTreeObserver.addOnScrollChangedListener {
val binding = _binding ?: return@addOnScrollChangedListener val viewBinding = _binding ?: return@addOnScrollChangedListener
// save the last scroll position to become used next time when the sheet is opened // save the last scroll position to become used next time when the sheet is opened
viewModel.currentCommentsPosition = layoutManager.findFirstVisibleItemPosition() viewModel.currentCommentsPosition = layoutManager.findFirstVisibleItemPosition()
@ -48,11 +49,11 @@ class CommentsMainFragment : Fragment() {
commentsSheetBinding?.btnScrollToTop?.isVisible = viewModel.currentCommentsPosition != 0 commentsSheetBinding?.btnScrollToTop?.isVisible = viewModel.currentCommentsPosition != 0
commentsSheetBinding?.btnScrollToTop?.setOnClickListener { commentsSheetBinding?.btnScrollToTop?.setOnClickListener {
// scroll back to the top / first comment // scroll back to the top / first comment
binding.commentsRV.smoothScrollToPosition(0) viewBinding.commentsRV.smoothScrollToPosition(0)
viewModel.currentCommentsPosition = 0 viewModel.currentCommentsPosition = 0
} }
if (!binding.commentsRV.canScrollVertically(1)) { if (!viewBinding.commentsRV.canScrollVertically(1)) {
viewModel.fetchNextComments() viewModel.fetchNextComments()
} }
} }