diff --git a/app/src/main/java/com/github/libretube/ui/preferences/MainSettings.kt b/app/src/main/java/com/github/libretube/ui/preferences/MainSettings.kt index 46f329822..d0ec43a28 100644 --- a/app/src/main/java/com/github/libretube/ui/preferences/MainSettings.kt +++ b/app/src/main/java/com/github/libretube/ui/preferences/MainSettings.kt @@ -2,8 +2,6 @@ package com.github.libretube.ui.preferences import android.os.Bundle import androidx.annotation.StringRes -import androidx.fragment.app.Fragment -import androidx.fragment.app.commitNow import androidx.lifecycle.lifecycleScope import androidx.preference.Preference import com.github.libretube.BuildConfig @@ -23,56 +21,6 @@ class MainSettings : BasePreferenceFragment() { override fun onCreatePreferences(savedInstanceState: Bundle?, rootKey: String?) { setPreferencesFromResource(R.xml.settings, rootKey) - val general = findPreference("general") - general?.setOnPreferenceClickListener { - navigateToSettingsFragment(GeneralSettings()) - } - - val instance = findPreference("instance") - instance?.setOnPreferenceClickListener { - navigateToSettingsFragment(InstanceSettings()) - } - - val appearance = findPreference("appearance") - appearance?.setOnPreferenceClickListener { - navigateToSettingsFragment(AppearanceSettings()) - } - - val sponsorBlock = findPreference("sponsorblock") - sponsorBlock?.setOnPreferenceClickListener { - navigateToSettingsFragment(SponsorBlockSettings()) - } - - val player = findPreference("player") - player?.setOnPreferenceClickListener { - navigateToSettingsFragment(PlayerSettings()) - } - - val audioVideo = findPreference("audio_video") - audioVideo?.setOnPreferenceClickListener { - navigateToSettingsFragment(AudioVideoSettings()) - } - - val history = findPreference("history") - history?.setOnPreferenceClickListener { - navigateToSettingsFragment(HistorySettings()) - } - - val notifications = findPreference("notifications") - notifications?.setOnPreferenceClickListener { - navigateToSettingsFragment(NotificationSettings()) - } - - val backupRestore = findPreference("backup_restore") - backupRestore?.setOnPreferenceClickListener { - navigateToSettingsFragment(BackupRestoreSettings()) - } - - val advanced = findPreference("advanced") - advanced?.setOnPreferenceClickListener { - navigateToSettingsFragment(AdvancedSettings()) - } - val update = findPreference("update") // set the version of the update preference @@ -117,11 +65,4 @@ class MainSettings : BasePreferenceFragment() { .show() } } - - private fun navigateToSettingsFragment(newFragment: Fragment): Boolean { - parentFragmentManager.commitNow { - replace(R.id.settings, newFragment) - } - return true - } } diff --git a/app/src/main/res/xml/settings.xml b/app/src/main/res/xml/settings.xml index d6edb9183..11cc67378 100644 --- a/app/src/main/res/xml/settings.xml +++ b/app/src/main/res/xml/settings.xml @@ -5,59 +5,69 @@