From 4502e07fc6d562840bfa4b259d0180d152217f98 Mon Sep 17 00:00:00 2001 From: Bnyro Date: Thu, 17 Nov 2022 16:06:06 +0100 Subject: [PATCH] remove unused reference --- .../ui/activities/OfflinePlayerActivity.kt | 1 - .../libretube/ui/fragments/PlayerFragment.kt | 1 - .../libretube/ui/views/CustomExoPlayerView.kt | 18 +++++++++--------- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/com/github/libretube/ui/activities/OfflinePlayerActivity.kt b/app/src/main/java/com/github/libretube/ui/activities/OfflinePlayerActivity.kt index 0606515f8..4f6d26638 100644 --- a/app/src/main/java/com/github/libretube/ui/activities/OfflinePlayerActivity.kt +++ b/app/src/main/java/com/github/libretube/ui/activities/OfflinePlayerActivity.kt @@ -68,7 +68,6 @@ class OfflinePlayerActivity : BaseActivity() { } binding.player.initialize( - supportFragmentManager, null, binding.doubleTapOverlay.binding, null diff --git a/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt b/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt index 15897b143..f9b14fbce 100644 --- a/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt +++ b/app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt @@ -757,7 +757,6 @@ class PlayerFragment : BaseFragment(), OnlinePlayerOptions { private fun initializePlayerView(response: Streams) { // initialize the player view actions binding.player.initialize( - childFragmentManager, this, doubleTapOverlayBinding, trackSelector diff --git a/app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt b/app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt index 22716453d..e506606ea 100644 --- a/app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt +++ b/app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt @@ -8,13 +8,13 @@ import android.os.Looper import android.util.AttributeSet import android.view.MotionEvent import android.view.View -import androidx.fragment.app.FragmentManager import com.github.libretube.R import com.github.libretube.databinding.DoubleTapOverlayBinding import com.github.libretube.databinding.ExoStyledPlayerControlViewBinding import com.github.libretube.extensions.toDp import com.github.libretube.obj.BottomSheetItem import com.github.libretube.ui.activities.MainActivity +import com.github.libretube.ui.base.BaseActivity import com.github.libretube.ui.interfaces.DoubleTapInterface import com.github.libretube.ui.interfaces.DoubleTapListener import com.github.libretube.ui.interfaces.OnlinePlayerOptions @@ -41,7 +41,6 @@ internal class CustomExoPlayerView( */ private var doubleTapListener: DoubleTapInterface? = null private var playerOptionsInterface: OnlinePlayerOptions? = null - private lateinit var childFragmentManager: FragmentManager private var trackSelector: TrackSelector? = null private val runnableHandler = Handler(Looper.getMainLooper()) @@ -58,6 +57,9 @@ internal class CustomExoPlayerView( private var resizeModePref = PlayerHelper.resizeModePref + private val supportFragmentManager + get() = (context as BaseActivity).supportFragmentManager + private fun toggleController() { if (isControllerFullyVisible) hideController() else showController() } @@ -73,12 +75,10 @@ internal class CustomExoPlayerView( } fun initialize( - childFragmentManager: FragmentManager, playerViewInterface: OnlinePlayerOptions?, doubleTapOverlayBinding: DoubleTapOverlayBinding, trackSelector: TrackSelector? ) { - this.childFragmentManager = childFragmentManager this.playerOptionsInterface = playerViewInterface this.doubleTapOverlayBinding = doubleTapOverlayBinding this.trackSelector = trackSelector @@ -219,7 +219,7 @@ internal class CustomExoPlayerView( } val bottomSheetFragment = BaseBottomSheet().setItems(items, null) - bottomSheetFragment.show(childFragmentManager, null) + bottomSheetFragment.show(supportFragmentManager, null) } } @@ -332,11 +332,11 @@ internal class CustomExoPlayerView( 1 -> autoplayEnabled = false } } - .show(childFragmentManager) + .show(supportFragmentManager) } override fun onPlaybackSpeedClicked() { - player?.let { PlaybackSpeedSheet(it).show(childFragmentManager) } + player?.let { PlaybackSpeedSheet(it).show(supportFragmentManager) } } override fun onResizeModeClicked() { @@ -354,7 +354,7 @@ internal class CustomExoPlayerView( .setSimpleItems(aspectRatioModeNames) { index -> resizeMode = aspectRatioModes[index] } - .show(childFragmentManager) + .show(supportFragmentManager) } override fun onRepeatModeClicked() { @@ -373,7 +373,7 @@ internal class CustomExoPlayerView( .setSimpleItems(repeatModeNames) { index -> player?.repeatMode = repeatModes[index] } - .show(childFragmentManager) + .show(supportFragmentManager) } override fun onConfigurationChanged(newConfig: Configuration?) {