From a7a885f88df512e51e42c810936e1213fd9255d0 Mon Sep 17 00:00:00 2001 From: Isira Seneviratne Date: Tue, 31 Jan 2023 07:30:16 +0530 Subject: [PATCH] Convert LocalPlaylistsDao methods to suspend functions. --- .../github/libretube/api/PlaylistsHelper.kt | 160 +++++++----------- .../libretube/db/dao/LocalPlaylistsDao.kt | 19 +-- .../ui/dialogs/DeletePlaylistDialog.kt | 52 +++--- 3 files changed, 94 insertions(+), 137 deletions(-) diff --git a/app/src/main/java/com/github/libretube/api/PlaylistsHelper.kt b/app/src/main/java/com/github/libretube/api/PlaylistsHelper.kt index 2930cbcf4..8b5bbd44d 100644 --- a/app/src/main/java/com/github/libretube/api/PlaylistsHelper.kt +++ b/app/src/main/java/com/github/libretube/api/PlaylistsHelper.kt @@ -12,7 +12,6 @@ import com.github.libretube.db.DatabaseHolder import com.github.libretube.db.obj.LocalPlaylist import com.github.libretube.enums.PlaylistType import com.github.libretube.extensions.TAG -import com.github.libretube.extensions.awaitQuery import com.github.libretube.extensions.toID import com.github.libretube.extensions.toLocalPlaylistItem import com.github.libretube.extensions.toStreamItem @@ -35,26 +34,22 @@ object PlaylistsHelper { private val token get() = PreferenceHelper.getToken() - val loggedIn: Boolean get() = token != "" + val loggedIn: Boolean get() = token.isNotEmpty() - suspend fun getPlaylists(): List { - if (loggedIn) return RetrofitInstance.authApi.getUserPlaylists(token) - - val localPlaylists = awaitQuery { + suspend fun getPlaylists(): List = withContext(Dispatchers.IO) { + if (loggedIn) { + RetrofitInstance.authApi.getUserPlaylists(token) + } else { DatabaseHolder.Database.localPlaylistsDao().getAll() + .map { + Playlists( + id = it.playlist.id.toString(), + name = it.playlist.name, + thumbnail = ProxyHelper.rewriteUrl(it.playlist.thumbnailUrl), + videos = it.videos.size.toLong() + ) + } } - val playlists = mutableListOf() - localPlaylists.forEach { - playlists.add( - Playlists( - id = it.playlist.id.toString(), - name = it.playlist.name, - thumbnail = ProxyHelper.rewriteUrl(it.playlist.thumbnailUrl), - videos = it.videos.size.toLong() - ) - ) - } - return playlists } suspend fun getPlaylist(playlistId: String): Playlist { @@ -63,9 +58,8 @@ object PlaylistsHelper { PlaylistType.PRIVATE -> RetrofitInstance.authApi.getPlaylist(playlistId) PlaylistType.PUBLIC -> RetrofitInstance.api.getPlaylist(playlistId) PlaylistType.LOCAL -> { - val relation = awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().getAll() - }.first { it.playlist.id.toString() == playlistId } + val relation = DatabaseHolder.Database.localPlaylistsDao().getAll() + .first { it.playlist.id.toString() == playlistId } return Playlist( name = relation.playlist.name, thumbnailUrl = ProxyHelper.rewriteUrl(relation.playlist.thumbnailUrl), @@ -81,33 +75,26 @@ object PlaylistsHelper { appContext: Context ): String? { if (!loggedIn) { - awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().createPlaylist( - LocalPlaylist( - name = playlistName, - thumbnailUrl = "" - ) - ) + val playlist = LocalPlaylist(name = playlistName, thumbnailUrl = "") + DatabaseHolder.Database.localPlaylistsDao().createPlaylist(playlist) + return DatabaseHolder.Database.localPlaylistsDao().getAll() + .last().playlist.id.toString() + } else { + val response = try { + RetrofitInstance.authApi.createPlaylist(token, Playlists(name = playlistName)) + } catch (e: IOException) { + appContext.toastFromMainThread(R.string.unknown_error) + return null + } catch (e: HttpException) { + Log.e(TAG(), e.toString()) + appContext.toastFromMainThread(R.string.server_error) + return null + } + if (response.playlistId != null) { + appContext.toastFromMainThread(R.string.playlistCreated) } - return awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().getAll() - }.last().playlist.id.toString() - } - val response = try { - RetrofitInstance.authApi.createPlaylist(token, Playlists(name = playlistName)) - } catch (e: IOException) { - appContext.toastFromMainThread(R.string.unknown_error) - return null - } catch (e: HttpException) { - Log.e(TAG(), e.toString()) - appContext.toastFromMainThread(R.string.server_error) - return null - } - if (response.playlistId != null) { - appContext.toastFromMainThread(R.string.playlistCreated) return response.playlistId } - return null } suspend fun addToPlaylist(playlistId: String, vararg videos: StreamItem): Boolean { @@ -117,22 +104,19 @@ object PlaylistsHelper { for (video in videos) { val localPlaylistItem = video.toLocalPlaylistItem(playlistId) - awaitQuery { - // avoid duplicated videos in a playlist - DatabaseHolder.Database.localPlaylistsDao() - .deletePlaylistItemsByVideoId(playlistId, localPlaylistItem.videoId) + // avoid duplicated videos in a playlist + DatabaseHolder.Database.localPlaylistsDao() + .deletePlaylistItemsByVideoId(playlistId, localPlaylistItem.videoId) - // add the new video to the database - DatabaseHolder.Database.localPlaylistsDao().addPlaylistVideo(localPlaylistItem) + // add the new video to the database + DatabaseHolder.Database.localPlaylistsDao().addPlaylistVideo(localPlaylistItem) - if (localPlaylist.playlist.thumbnailUrl == "") { - // set the new playlist thumbnail URL - localPlaylistItem.thumbnailUrl?.let { - localPlaylist.playlist.thumbnailUrl = it - DatabaseHolder.Database.localPlaylistsDao().updatePlaylist( - localPlaylist.playlist - ) - } + val playlist = localPlaylist.playlist + if (playlist.thumbnailUrl == "") { + // set the new playlist thumbnail URL + localPlaylistItem.thumbnailUrl?.let { + playlist.thumbnailUrl = it + DatabaseHolder.Database.localPlaylistsDao().updatePlaylist(playlist) } } } @@ -144,61 +128,41 @@ object PlaylistsHelper { } suspend fun renamePlaylist(playlistId: String, newName: String): Boolean { - if (!loggedIn) { - val playlist = awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().getAll() - }.first { it.playlist.id.toString() == playlistId }.playlist + return if (!loggedIn) { + val playlist = DatabaseHolder.Database.localPlaylistsDao().getAll() + .first { it.playlist.id.toString() == playlistId }.playlist playlist.name = newName - awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().updatePlaylist(playlist) - } - return true + DatabaseHolder.Database.localPlaylistsDao().updatePlaylist(playlist) + true + } else { + val playlist = PlaylistId(playlistId, newName = newName) + RetrofitInstance.authApi.renamePlaylist(token, playlist).playlistId != null } - - return RetrofitInstance.authApi.renamePlaylist( - token, - PlaylistId(playlistId, newName = newName) - ).playlistId != null } suspend fun removeFromPlaylist(playlistId: String, index: Int) { if (!loggedIn) { - val transaction = awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().getAll() - }.first { it.playlist.id.toString() == playlistId } - awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().removePlaylistVideo( - transaction.videos[index] - ) - } + val transaction = DatabaseHolder.Database.localPlaylistsDao().getAll() + .first { it.playlist.id.toString() == playlistId } + DatabaseHolder.Database.localPlaylistsDao().removePlaylistVideo( + transaction.videos[index] + ) if (transaction.videos.size > 1) { if (index == 0) { transaction.videos[1].thumbnailUrl?.let { transaction.playlist.thumbnailUrl = it } - awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().updatePlaylist( - transaction.playlist - ) - } + DatabaseHolder.Database.localPlaylistsDao().updatePlaylist(transaction.playlist) } return } // remove thumbnail if playlist now empty - awaitQuery { - transaction.playlist.thumbnailUrl = "" - DatabaseHolder.Database.localPlaylistsDao().updatePlaylist(transaction.playlist) - } - return + transaction.playlist.thumbnailUrl = "" + DatabaseHolder.Database.localPlaylistsDao().updatePlaylist(transaction.playlist) + } else { + val playlist = PlaylistId(playlistId = playlistId, index = index) + RetrofitInstance.authApi.removeFromPlaylist(PreferenceHelper.getToken(), playlist) } - - RetrofitInstance.authApi.removeFromPlaylist( - PreferenceHelper.getToken(), - PlaylistId( - playlistId = playlistId, - index = index - ) - ) } suspend fun importPlaylists(appContext: Context, playlists: List) { diff --git a/app/src/main/java/com/github/libretube/db/dao/LocalPlaylistsDao.kt b/app/src/main/java/com/github/libretube/db/dao/LocalPlaylistsDao.kt index f0eb47950..bba3429fe 100644 --- a/app/src/main/java/com/github/libretube/db/dao/LocalPlaylistsDao.kt +++ b/app/src/main/java/com/github/libretube/db/dao/LocalPlaylistsDao.kt @@ -14,29 +14,26 @@ import com.github.libretube.db.obj.LocalPlaylistWithVideos interface LocalPlaylistsDao { @Transaction @Query("SELECT * FROM LocalPlaylist") - fun getAll(): List + suspend fun getAll(): List @Insert - fun createPlaylist(playlist: LocalPlaylist) + suspend fun createPlaylist(playlist: LocalPlaylist) @Update - fun updatePlaylist(playlist: LocalPlaylist) - - @Delete - fun deletePlaylist(playlist: LocalPlaylist) + suspend fun updatePlaylist(playlist: LocalPlaylist) @Query("DELETE FROM localPlaylist WHERE id = :playlistId") - fun deletePlaylistById(playlistId: String) + suspend fun deletePlaylistById(playlistId: String) @Insert - fun addPlaylistVideo(playlistVideo: LocalPlaylistItem) + suspend fun addPlaylistVideo(playlistVideo: LocalPlaylistItem) @Delete - fun removePlaylistVideo(playlistVideo: LocalPlaylistItem) + suspend fun removePlaylistVideo(playlistVideo: LocalPlaylistItem) @Query("DELETE FROM localPlaylistItem WHERE playlistId = :playlistId") - fun deletePlaylistItemsByPlaylistId(playlistId: String) + suspend fun deletePlaylistItemsByPlaylistId(playlistId: String) @Query("DELETE FROM localPlaylistItem WHERE playlistId = :playlistId AND videoId = :videoId") - fun deletePlaylistItemsByVideoId(playlistId: String, videoId: String) + suspend fun deletePlaylistItemsByVideoId(playlistId: String, videoId: String) } diff --git a/app/src/main/java/com/github/libretube/ui/dialogs/DeletePlaylistDialog.kt b/app/src/main/java/com/github/libretube/ui/dialogs/DeletePlaylistDialog.kt index 091966ad8..9c0f92652 100644 --- a/app/src/main/java/com/github/libretube/ui/dialogs/DeletePlaylistDialog.kt +++ b/app/src/main/java/com/github/libretube/ui/dialogs/DeletePlaylistDialog.kt @@ -4,16 +4,15 @@ import android.app.Dialog import android.os.Bundle import android.util.Log import androidx.fragment.app.DialogFragment +import androidx.lifecycle.lifecycleScope import com.github.libretube.R import com.github.libretube.api.RetrofitInstance import com.github.libretube.api.obj.PlaylistId import com.github.libretube.db.DatabaseHolder import com.github.libretube.enums.PlaylistType import com.github.libretube.extensions.TAG -import com.github.libretube.extensions.awaitQuery import com.github.libretube.util.PreferenceHelper import com.google.android.material.dialog.MaterialAlertDialogBuilder -import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext @@ -28,44 +27,41 @@ class DeletePlaylistDialog( .setTitle(R.string.deletePlaylist) .setMessage(R.string.areYouSure) .setPositiveButton(R.string.yes) { _, _ -> - PreferenceHelper.getToken() - deletePlaylist() + lifecycleScope.launch(Dispatchers.IO) { + deletePlaylist() + } } .setNegativeButton(R.string.cancel, null) .show() } - private fun deletePlaylist() { + private suspend fun deletePlaylist() { if (playlistType == PlaylistType.LOCAL) { - awaitQuery { - DatabaseHolder.Database.localPlaylistsDao().deletePlaylistById(playlistId) - DatabaseHolder.Database.localPlaylistsDao().deletePlaylistItemsByPlaylistId( - playlistId - ) + DatabaseHolder.Database.localPlaylistsDao().deletePlaylistById(playlistId) + DatabaseHolder.Database.localPlaylistsDao().deletePlaylistItemsByPlaylistId(playlistId) + withContext(Dispatchers.Main) { + onSuccess() } - onSuccess.invoke() return } - CoroutineScope(Dispatchers.IO).launch { - val response = try { - RetrofitInstance.authApi.deletePlaylist( - PreferenceHelper.getToken(), - PlaylistId(playlistId) - ) - } catch (e: Exception) { - Log.e(TAG(), e.toString()) - return@launch - } - try { - if (response.message == "ok") { - withContext(Dispatchers.Main) { - onSuccess.invoke() - } + val response = try { + RetrofitInstance.authApi.deletePlaylist( + PreferenceHelper.getToken(), + PlaylistId(playlistId) + ) + } catch (e: Exception) { + Log.e(TAG(), e.toString()) + return + } + try { + if (response.message == "ok") { + withContext(Dispatchers.Main) { + onSuccess() } - } catch (e: Exception) { - Log.e(TAG(), e.toString()) } + } catch (e: Exception) { + Log.e(TAG(), e.toString()) } } }