From 21b8e8bbc0cc64f469bcf2d28e04319bbd895db9 Mon Sep 17 00:00:00 2001
From: Bnyro <yannick.fehler@web.de>
Date: Sat, 11 Jun 2022 13:04:33 +0200
Subject: [PATCH] codebase

---
 .../java/com/github/libretube/MainActivity.kt |   2 +-
 .../libretube/dialogs/CustomInstanceDialog.kt |  43 ++++++++
 .../github/libretube/dialogs/ShareDialog.kt   |   2 +-
 .../libretube/preferences/InstanceSettings.kt |  34 ++++--
 app/src/main/res/drawable/ic_add_instance.xml |  10 ++
 .../res/layout/dialog_custom_instance.xml     | 103 ++++++++++++++++++
 app/src/main/res/values/strings.xml           |   6 +-
 app/src/main/res/xml/instance_settings.xml    |   9 +-
 8 files changed, 192 insertions(+), 17 deletions(-)
 create mode 100644 app/src/main/java/com/github/libretube/dialogs/CustomInstanceDialog.kt
 create mode 100644 app/src/main/res/drawable/ic_add_instance.xml
 create mode 100644 app/src/main/res/layout/dialog_custom_instance.xml

diff --git a/app/src/main/java/com/github/libretube/MainActivity.kt b/app/src/main/java/com/github/libretube/MainActivity.kt
index a20f7971d..183fe853f 100644
--- a/app/src/main/java/com/github/libretube/MainActivity.kt
+++ b/app/src/main/java/com/github/libretube/MainActivity.kt
@@ -53,7 +53,7 @@ class MainActivity : AppCompatActivity() {
         CronetHelper.initCronet(this.applicationContext)
         val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(this)
         RetrofitInstance.url =
-            sharedPreferences.getString("instance", "https://pipedapi.kavin.rocks/")!!
+            sharedPreferences.getString("selectInstance", "https://pipedapi.kavin.rocks/")!!
         SponsorBlockSettings.sponsorBlockEnabled =
             sharedPreferences.getBoolean("sb_enabled_key", false)
         SponsorBlockSettings.sponsorNotificationsEnabled =
diff --git a/app/src/main/java/com/github/libretube/dialogs/CustomInstanceDialog.kt b/app/src/main/java/com/github/libretube/dialogs/CustomInstanceDialog.kt
new file mode 100644
index 000000000..56c0f116b
--- /dev/null
+++ b/app/src/main/java/com/github/libretube/dialogs/CustomInstanceDialog.kt
@@ -0,0 +1,43 @@
+package com.github.libretube.dialogs
+
+import android.app.Dialog
+import android.os.Bundle
+import android.util.TypedValue
+import android.view.View
+import android.widget.Button
+import android.widget.TextView
+import androidx.core.text.HtmlCompat
+import androidx.fragment.app.DialogFragment
+import com.github.libretube.R
+import com.google.android.material.dialog.MaterialAlertDialogBuilder
+import com.google.android.material.textfield.TextInputEditText
+
+class CustomInstanceDialog : DialogFragment() {
+    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
+        return activity?.let {
+            val builder = MaterialAlertDialogBuilder(it)
+            val inflater = requireActivity().layoutInflater
+            val view: View = inflater.inflate(R.layout.dialog_custom_instance, null)
+
+            val instanceNameEditText = view.findViewById<TextInputEditText>(R.id.instanceName)
+            val instanceApiUrlEditText = view.findViewById<TextInputEditText>(R.id.instanceApiUrl)
+            val addInstanceButton = view.findViewById<Button>(R.id.addInstance)
+            addInstanceButton.setOnClickListener {
+                val instanceName = instanceNameEditText.text
+                val instanceApiUrl = instanceApiUrlEditText.text
+            }
+
+            val typedValue = TypedValue()
+            this.requireActivity().theme.resolveAttribute(R.attr.colorPrimaryDark, typedValue, true)
+            val hexColor = String.format("#%06X", (0xFFFFFF and typedValue.data))
+            val appName = HtmlCompat.fromHtml(
+                "Libre<span  style='color:$hexColor';>Tube</span>",
+                HtmlCompat.FROM_HTML_MODE_COMPACT
+            )
+            view.findViewById<TextView>(R.id.title).text = appName
+
+            builder.setView(view)
+            builder.create()
+        } ?: throw IllegalStateException("Activity cannot be null")
+    }
+}
\ No newline at end of file
diff --git a/app/src/main/java/com/github/libretube/dialogs/ShareDialog.kt b/app/src/main/java/com/github/libretube/dialogs/ShareDialog.kt
index d78c486e6..29b708ad3 100644
--- a/app/src/main/java/com/github/libretube/dialogs/ShareDialog.kt
+++ b/app/src/main/java/com/github/libretube/dialogs/ShareDialog.kt
@@ -16,7 +16,7 @@ class ShareDialog(private val videoId: String) : DialogFragment() {
             val sharedPreferences =
                 PreferenceManager.getDefaultSharedPreferences(requireContext())
             val instancePref = sharedPreferences.getString(
-                "instance",
+                "selectInstance",
                 "https://pipedapi.kavin.rocks"
             )!!
             val instance = "&instance=${URLEncoder.encode(instancePref, "UTF-8")}"
diff --git a/app/src/main/java/com/github/libretube/preferences/InstanceSettings.kt b/app/src/main/java/com/github/libretube/preferences/InstanceSettings.kt
index 21753bb8d..9b733af99 100644
--- a/app/src/main/java/com/github/libretube/preferences/InstanceSettings.kt
+++ b/app/src/main/java/com/github/libretube/preferences/InstanceSettings.kt
@@ -16,10 +16,12 @@ import androidx.core.app.ActivityCompat
 import androidx.core.content.ContextCompat
 import androidx.fragment.app.Fragment
 import androidx.lifecycle.lifecycleScope
+import androidx.preference.EditTextPreference
 import androidx.preference.ListPreference
 import androidx.preference.Preference
 import androidx.preference.PreferenceFragmentCompat
 import com.github.libretube.R
+import com.github.libretube.dialogs.CustomInstanceDialog
 import com.github.libretube.dialogs.LoginDialog
 import com.github.libretube.requireMainActivityRestart
 import com.github.libretube.util.RetrofitInstance
@@ -110,19 +112,19 @@ class InstanceSettings : PreferenceFragmentCompat() {
         val topBarTextView = activity?.findViewById<TextView>(R.id.topBar_textView)
         topBarTextView?.text = getString(R.string.instance)
 
-        val instance = findPreference<ListPreference>("instance_server")
+        val instance = findPreference<ListPreference>("selectInstance")
         fetchInstance()
         instance?.setOnPreferenceChangeListener { _, newValue ->
             RetrofitInstance.url = newValue.toString()
             RetrofitInstance.lazyMgr.reset()
-            val sharedPref = context?.getSharedPreferences("token", Context.MODE_PRIVATE)
-            if (sharedPref?.getString("token", "") != "") {
-                with(sharedPref!!.edit()) {
-                    putString("token", "")
-                    apply()
-                }
-                Toast.makeText(context, R.string.loggedout, Toast.LENGTH_SHORT).show()
-            }
+            logout()
+            true
+        }
+
+        val customInstance = findPreference<Preference>("customInstance")
+        customInstance?.setOnPreferenceClickListener {
+            val newFragment = CustomInstanceDialog()
+            newFragment.show(childFragmentManager, "CustomInstanceDialog")
             true
         }
 
@@ -188,6 +190,18 @@ class InstanceSettings : PreferenceFragmentCompat() {
         }
     }
 
+    private fun logout() {
+        val sharedPref = context?.getSharedPreferences("token", Context.MODE_PRIVATE)
+        val token = sharedPref?.getString("token", "")
+        if (token != "") {
+            with(sharedPref!!.edit()) {
+                putString("token", "")
+                apply()
+            }
+            Toast.makeText(context, R.string.loggedout, Toast.LENGTH_SHORT).show()
+        }
+    }
+
     private fun fetchInstance() {
         lifecycleScope.launchWhenCreated {
             val response = try {
@@ -212,7 +226,7 @@ class InstanceSettings : PreferenceFragmentCompat() {
             val entries = listEntries.toTypedArray<CharSequence>()
             val entryValues = listEntryValues.toTypedArray<CharSequence>()
             runOnUiThread {
-                val instance = findPreference<ListPreference>("instance_server")
+                val instance = findPreference<ListPreference>("officialInstance")
                 instance?.entries = entries
                 instance?.entryValues = entryValues
                 instance?.summaryProvider =
diff --git a/app/src/main/res/drawable/ic_add_instance.xml b/app/src/main/res/drawable/ic_add_instance.xml
new file mode 100644
index 000000000..d5d34b102
--- /dev/null
+++ b/app/src/main/res/drawable/ic_add_instance.xml
@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:tint="?android:attr/colorControlNormal"
+    android:viewportWidth="24"
+    android:viewportHeight="24">
+    <path
+        android:fillColor="@android:color/black"
+        android:pathData="M4,6L2,6v14c0,1.1 0.9,2 2,2h14v-2L4,20L4,6zM20,2L8,2c-1.1,0 -2,0.9 -2,2v12c0,1.1 0.9,2 2,2h12c1.1,0 2,-0.9 2,-2L22,4c0,-1.1 -0.9,-2 -2,-2zM19,11h-4v4h-2v-4L9,11L9,9h4L13,5h2v4h4v2z" />
+</vector>
diff --git a/app/src/main/res/layout/dialog_custom_instance.xml b/app/src/main/res/layout/dialog_custom_instance.xml
new file mode 100644
index 000000000..769d84a59
--- /dev/null
+++ b/app/src/main/res/layout/dialog_custom_instance.xml
@@ -0,0 +1,103 @@
+<?xml version="1.0" encoding="utf-8"?>
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    android:orientation="vertical"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content">
+
+
+    <TextView
+        android:id="@+id/title"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:text="@string/app_name"
+        android:gravity="center"
+        android:layout_margin="10dp"
+        android:textSize="20sp" />
+
+    <com.google.android.material.textfield.TextInputLayout
+        style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        app:hintEnabled="false"
+        android:layout_marginTop="16dp"
+        android:layout_marginLeft="10dp"
+        android:layout_marginRight="10dp"
+        android:layout_marginBottom="4dp"
+
+        app:boxCornerRadiusBottomStart="15dp"
+        app:boxCornerRadiusBottomEnd="15dp"
+        app:boxCornerRadiusTopEnd="15dp"
+        app:boxCornerRadiusTopStart="15dp">
+
+        <com.google.android.material.textfield.TextInputEditText
+            android:id="@+id/instanceName"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:hint="@string/instance_name"
+            android:inputType="text"
+            android:padding="12dp" />
+    </com.google.android.material.textfield.TextInputLayout>
+
+    <com.google.android.material.textfield.TextInputLayout
+        style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        app:hintEnabled="false"
+        android:layout_marginTop="16dp"
+        android:layout_marginLeft="10dp"
+        android:layout_marginRight="10dp"
+        android:layout_marginBottom="10dp"
+
+        app:boxCornerRadiusBottomStart="15dp"
+        app:boxCornerRadiusBottomEnd="15dp"
+        app:boxCornerRadiusTopEnd="15dp"
+        app:boxCornerRadiusTopStart="15dp"
+
+        >
+
+        <com.google.android.material.textfield.TextInputEditText
+            android:id="@+id/instanceApiUrl"
+            android:inputType="text"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:hint="@string/instance_api_url"
+            android:padding="12dp" />
+    </com.google.android.material.textfield.TextInputLayout>
+
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal"
+        android:gravity="end">
+
+        <Button
+            android:id="@+id/cancel"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:text="@string/cancel"
+            android:layout_gravity="end"
+            android:backgroundTint="@android:color/transparent"
+            android:textColor="?attr/colorPrimary"
+            android:textSize="14sp"
+            android:padding="8dp"
+            android:layout_marginBottom="8dp"
+            style="?android:attr/buttonBarButtonStyle" />
+
+        <Button
+            android:id="@+id/addInstance"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:text="@string/addInstance"
+            android:layout_gravity="end"
+            android:backgroundTint="@android:color/transparent"
+            android:textColor="?attr/colorPrimary"
+            android:textSize="14sp"
+            android:padding="8dp"
+            android:layout_marginEnd="8dp"
+            android:layout_marginBottom="8dp"
+            style="?android:attr/buttonBarButtonStyle" />
+
+    </LinearLayout>
+
+</LinearLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index d3af92c30..19ae53740 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -24,7 +24,7 @@
     <string name="already_logged_in">Already logged in. You may log out of your account.</string>
     <string name="login_first">Please log in and try again.</string>
     <string name="instances">Choose an instance</string>
-    <string name="customInstance">Add a custom instance</string>
+    <string name="customInstance">Custom instance</string>
     <string name="region">Region</string>
     <string name="login_register">Log in/register</string>
     <string name="please_login">Please log in or register in the settings first.</string>
@@ -162,4 +162,8 @@
     <string name="flameIcon">Flying flame</string>
     <string name="birdIcon">Boosted bird</string>
     <string name="instance_summary">Piped, login, subscriptions</string>
+    <string name="customInstance_summary">Add a custom instance (on your own risk)</string>
+    <string name="instance_name">Instance name</string>
+    <string name="instance_api_url">Instance API url</string>
+    <string name="addInstance">Add Instance</string>
 </resources>
diff --git a/app/src/main/res/xml/instance_settings.xml b/app/src/main/res/xml/instance_settings.xml
index f76aa1fe1..15846fa7e 100644
--- a/app/src/main/res/xml/instance_settings.xml
+++ b/app/src/main/res/xml/instance_settings.xml
@@ -9,13 +9,14 @@
             app:defaultValue="https://pipedapi.kavin.rocks/"
             app:entries="@array/instances"
             app:entryValues="@array/instancesValue"
-            app:key="instance_server"
+            app:key="selectInstance"
             app:title="@string/instances" />
 
-        <EditTextPreference
-            app:isPreferenceVisible="false"
+        <Preference
             app:key="customInstance"
-            app:title="@string/customInstance" />
+            app:title="@string/customInstance"
+            app:summary="@string/customInstance_summary"
+            android:icon="@drawable/ic_add_instance" />
 
         <Preference
             android:icon="@drawable/ic_login"