Simplify fetch and auth instance logic

app/src/main/java/com/github/libretube/LibreTubeApp.kt

@@ -33,7 +33,6 @@ class LibreTubeApp : Application() {
         /**
          * Set the api and the auth api url
          */
-        RetrofitInstance.initialize()
         ImageHelper.initializeImageLoader(this)
 
         /**

app/src/main/java/com/github/libretube/api/RetrofitInstance.kt

@@ -9,8 +9,19 @@ import retrofit2.Retrofit
 import retrofit2.create
 
 object RetrofitInstance {
-    lateinit var url: String
+    private val url get() = PreferenceHelper.getString(PreferenceKeys.FETCH_INSTANCE, PIPED_API_URL)
-    lateinit var authUrl: String
+    private val authUrl
+        get() = when (PreferenceHelper.getBoolean(
+            PreferenceKeys.AUTH_INSTANCE_TOGGLE,
+            false
+        )) {
+            true -> PreferenceHelper.getString(
+                PreferenceKeys.AUTH_INSTANCE,
+                PIPED_API_URL
+            )
+            false -> url
+        }
+
     val lazyMgr = resettableManager()
     private val kotlinxConverterFactory = JsonHelper.json
         .asConverterFactory("application/json".toMediaType())
@@ -41,27 +52,4 @@ object RetrofitInstance {
             .build()
             .create<ExternalApi>()
     }
-
-    /**
-     * Set the api urls needed for the [RetrofitInstance]
-     */
-    fun initialize() {
-        url =
-            PreferenceHelper.getString(PreferenceKeys.FETCH_INSTANCE, PIPED_API_URL)
-        // set auth instance
-        authUrl =
-            if (
-                PreferenceHelper.getBoolean(
-                    PreferenceKeys.AUTH_INSTANCE_TOGGLE,
-                    false
-                )
-            ) {
-                PreferenceHelper.getString(
-                    PreferenceKeys.AUTH_INSTANCE,
-                    PIPED_API_URL
-                )
-            } else {
-                url
-            }
-    }
 }

app/src/main/java/com/github/libretube/ui/activities/WelcomeActivity.kt

@@ -75,7 +75,6 @@ class WelcomeActivity : BaseActivity() {
 
     private fun startMainActivity() {
         // refresh the api urls since they have changed likely
-        RetrofitInstance.initialize()
         RetrofitInstance.lazyMgr.reset()
         val mainActivityIntent = Intent(this@WelcomeActivity, MainActivity::class.java)
         startActivity(mainActivityIntent)

app/src/main/java/com/github/libretube/ui/dialogs/LoginDialog.kt

@@ -65,7 +65,6 @@ class LoginDialog(
 
     private fun signIn(username: String, password: String, createNewAccount: Boolean = false) {
         val login = Login(username, password)
-        Log.e("url", RetrofitInstance.authUrl)
         lifecycleScope.launch(Dispatchers.IO) {
             val response = try {
                 if (createNewAccount) {

app/src/main/java/com/github/libretube/ui/preferences/InstanceSettings.kt

@@ -55,10 +55,8 @@ class InstanceSettings : BasePreferenceFragment() {
             }
         }
 
-        instancePref.setOnPreferenceChangeListener { _, newValue ->
+        instancePref.setOnPreferenceChangeListener { _, _ ->
-            RetrofitInstance.url = newValue.toString()
             if (!authInstanceToggle.isChecked) {
-                RetrofitInstance.authUrl = newValue.toString()
                 logoutAndUpdateUI()
             }
             RetrofitInstance.lazyMgr.reset()
@@ -66,21 +64,13 @@ class InstanceSettings : BasePreferenceFragment() {
             true
         }
 
-        authInstance.setOnPreferenceChangeListener { _, newValue ->
+        authInstance.setOnPreferenceChangeListener { _, _ ->
-            // save new auth url
-            RetrofitInstance.authUrl = newValue.toString()
             RetrofitInstance.lazyMgr.reset()
             logoutAndUpdateUI()
             true
         }
 
-        authInstanceToggle.setOnPreferenceChangeListener { _, newValue ->
+        authInstanceToggle.setOnPreferenceChangeListener { _, _ ->
-            // either use new auth url or the normal api url if auth instance disabled
-            RetrofitInstance.authUrl = if (newValue == false) {
-                RetrofitInstance.url
-            } else {
-                authInstance.value
-            }
             RetrofitInstance.lazyMgr.reset()
             logoutAndUpdateUI()
             true