From 1dcc408c852810601fb2c2891b2b3c34b0f21f6d Mon Sep 17 00:00:00 2001 From: Bnyro Date: Mon, 18 Nov 2024 18:55:29 +0100 Subject: [PATCH] fix: crash when videoId is unitialized --- .../java/com/github/libretube/services/AbstractPlayerService.kt | 2 ++ .../java/com/github/libretube/services/OfflinePlayerService.kt | 2 ++ 2 files changed, 4 insertions(+) diff --git a/app/src/main/java/com/github/libretube/services/AbstractPlayerService.kt b/app/src/main/java/com/github/libretube/services/AbstractPlayerService.kt index a360fc5c3..770c66992 100644 --- a/app/src/main/java/com/github/libretube/services/AbstractPlayerService.kt +++ b/app/src/main/java/com/github/libretube/services/AbstractPlayerService.kt @@ -307,6 +307,8 @@ abstract class AbstractPlayerService : MediaLibraryService(), MediaLibrarySessio super.onDestroy() } + fun isVideoIdInitialized() = this::videoId.isInitialized + /** * Stop the service when app is removed from the task manager. */ diff --git a/app/src/main/java/com/github/libretube/services/OfflinePlayerService.kt b/app/src/main/java/com/github/libretube/services/OfflinePlayerService.kt index c5d5b9746..4b42ba8e1 100644 --- a/app/src/main/java/com/github/libretube/services/OfflinePlayerService.kt +++ b/app/src/main/java/com/github/libretube/services/OfflinePlayerService.kt @@ -84,6 +84,8 @@ open class OfflinePlayerService : AbstractPlayerService() { * Attempt to start an audio player with the given download items */ override suspend fun startPlayback() { + if (!isVideoIdInitialized()) return + val downloadWithItems = withContext(Dispatchers.IO) { Database.downloadDao().findById(videoId) }!!