Merge pull request #758 from Bnyro/master

btn UI improvements and bug fixes

app/src/main/java/com/github/libretube/adapters/SearchAdapter.kt

@@ -177,11 +177,13 @@ class SearchAdapter(
                 binding.searchSubButton.setOnClickListener {
                     if (!isSubscribed) {
                         subscribe(token, channelId)
-                        binding.searchSubButton.text = binding.root.context.getString(R.string.unsubscribe)
+                        binding.searchSubButton.text =
+                            binding.root.context.getString(R.string.unsubscribe)
                         isSubscribed = true
                     } else {
                         unsubscribe(token, channelId)
-                        binding.searchSubButton.text = binding.root.context.getString(R.string.subscribe)
+                        binding.searchSubButton.text =
+                            binding.root.context.getString(R.string.subscribe)
                         isSubscribed = false
                     }
                 }

app/src/main/java/com/github/libretube/adapters/SubscriptionChannelAdapter.kt

@@ -17,8 +17,6 @@ import com.squareup.picasso.Picasso
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
-import retrofit2.HttpException
-import java.io.IOException
 
 class SubscriptionChannelAdapter(private val subscriptions: MutableList<Subscription>) :
     RecyclerView.Adapter<SubscriptionChannelViewHolder>() {
@@ -68,17 +66,14 @@ class SubscriptionChannelAdapter(private val subscriptions: MutableList<Subscrip
     private fun subscribe(context: Context, channelId: String) {
         fun run() {
             CoroutineScope(Dispatchers.IO).launch {
-                val response = try {
+                try {
                     val token = PreferenceHelper.getToken(context)
                     RetrofitInstance.authApi.subscribe(
                         token,
                         Subscribe(channelId)
                     )
-                } catch (e: IOException) {
+                } catch (e: Exception) {
-                    println(e)
+                    Log.e(TAG, e.toString())
-                    Log.e(TAG, "IOException, you might not have internet connection")
-                } catch (e: HttpException) {
-                    Log.e(TAG, "HttpException, unexpected response")
                 }
                 subscribed = true
                 isLoading = false
@@ -90,17 +85,14 @@ class SubscriptionChannelAdapter(private val subscriptions: MutableList<Subscrip
     private fun unsubscribe(context: Context, channelId: String) {
         fun run() {
             CoroutineScope(Dispatchers.IO).launch {
-                val response = try {
+                try {
                     val token = PreferenceHelper.getToken(context)
                     RetrofitInstance.authApi.unsubscribe(
                         token,
                         Subscribe(channelId)
                     )
-                } catch (e: IOException) {
+                } catch (e: Exception) {
-                    println(e)
+                    Log.e(TAG, e.toString())
-                    Log.e(TAG, "IOException, you might not have internet connection")
-                } catch (e: HttpException) {
-                    Log.e(TAG, "HttpException, unexpected response")
                 }
                 subscribed = false
                 isLoading = false

app/src/main/java/com/github/libretube/fragments/ChannelFragment.kt

@@ -16,7 +16,6 @@ import com.github.libretube.obj.Subscribe
 import com.github.libretube.preferences.PreferenceHelper
 import com.github.libretube.util.RetrofitInstance
 import com.github.libretube.util.formatShort
-import com.google.android.material.button.MaterialButton
 import com.squareup.picasso.Picasso
 import retrofit2.HttpException
 import java.io.IOException
@@ -58,7 +57,7 @@ class ChannelFragment : Fragment() {
             binding.channelRefresh.isRefreshing = true
             fetchChannel()
             if (PreferenceHelper.getToken(requireContext()) != "") {
-                isSubscribed(binding.channelSubscribe)
+                isSubscribed()
             }
         }
         refreshChannel()
@@ -81,7 +80,7 @@ class ChannelFragment : Fragment() {
             }
     }
 
-    private fun isSubscribed(button: MaterialButton) {
+    private fun isSubscribed() {
         @SuppressLint("ResourceAsColor")
         fun run() {
             lifecycleScope.launchWhenCreated {
@@ -91,28 +90,26 @@ class ChannelFragment : Fragment() {
                         channelId!!,
                         token
                     )
-                } catch (e: IOException) {
+                } catch (e: Exception) {
-                    println(e)
+                    Log.e(TAG, e.toString())
-                    Log.e(TAG, "IOException, you might not have internet connection")
-                    return@launchWhenCreated
-                } catch (e: HttpException) {
-                    Log.e(TAG, "HttpException, unexpected response")
                     return@launchWhenCreated
                 }
 
                 runOnUiThread {
                     if (response.subscribed == true) {
                         isSubscribed = true
-                        button.text = getString(R.string.unsubscribe)
+                        binding.channelSubscribe.text = getString(R.string.unsubscribe)
                     }
                     if (response.subscribed != null) {
-                        button.setOnClickListener {
+                        binding.channelSubscribe.apply {
-                            if (isSubscribed) {
+                            setOnClickListener {
-                                unsubscribe()
+                                text = if (isSubscribed) {
-                                button.text = getString(R.string.subscribe)
+                                    unsubscribe()
-                            } else {
+                                    getString(R.string.subscribe)
-                                subscribe()
+                                } else {
-                                button.text = getString(R.string.unsubscribe)
+                                    subscribe()
+                                    getString(R.string.unsubscribe)
+                                }
                             }
                         }
                     }
@@ -125,19 +122,14 @@ class ChannelFragment : Fragment() {
     private fun subscribe() {
         fun run() {
             lifecycleScope.launchWhenCreated {
-                val response = try {
+                try {
                     val token = PreferenceHelper.getToken(requireContext())
                     RetrofitInstance.authApi.subscribe(
                         token,
                         Subscribe(channelId)
                     )
-                } catch (e: IOException) {
+                } catch (e: Exception) {
-                    println(e)
+                    Log.e(TAG, e.toString())
-                    Log.e(TAG, "IOException, you might not have internet connection")
-                    return@launchWhenCreated
-                } catch (e: HttpException) {
-                    Log.e(TAG, "HttpException, unexpected response$e")
-                    return@launchWhenCreated
                 }
                 isSubscribed = true
             }
@@ -148,19 +140,14 @@ class ChannelFragment : Fragment() {
     private fun unsubscribe() {
         fun run() {
             lifecycleScope.launchWhenCreated {
-                val response = try {
+                try {
                     val token = PreferenceHelper.getToken(requireContext())
                     RetrofitInstance.authApi.unsubscribe(
                         token,
                         Subscribe(channelId)
                     )
-                } catch (e: IOException) {
+                } catch (e: Exception) {
-                    println(e)
+                    Log.e(TAG, e.toString())
-                    Log.e(TAG, "IOException, you might not have internet connection")
-                    return@launchWhenCreated
-                } catch (e: HttpException) {
-                    Log.e(TAG, "HttpException, unexpected response")
-                    return@launchWhenCreated
                 }
                 isSubscribed = false
             }

app/src/main/java/com/github/libretube/views/DoubleClickListener.kt

@@ -9,28 +9,30 @@ class DoubleClickListener(
     private val callback: Callback
 ) : View.OnClickListener {
     private var lastClicked: Long = -1L
-    private var doubleClicked: Boolean = false
 
     override fun onClick(v: View?) {
         lastClicked = when {
             lastClicked == -1L -> {
-                doubleClicked = false
+                checkForSingleClick()
                 System.currentTimeMillis()
             }
             isDoubleClicked() -> {
-                doubleClicked = true
                 callback.doubleClicked()
                 -1L
             }
             else -> {
-                Handler(Looper.getMainLooper()).postDelayed({
+                checkForSingleClick()
-                    if (!doubleClicked) callback.singleClicked()
-                }, doubleClickTimeLimitMills)
                 System.currentTimeMillis()
             }
         }
     }
 
+    private fun checkForSingleClick() {
+        Handler(Looper.getMainLooper()).postDelayed({
+            if (lastClicked != -1L) callback.singleClicked()
+        }, doubleClickTimeLimitMills)
+    }
+
     private fun getTimeDiff(from: Long, to: Long): Long {
         return to - from
     }

app/src/main/res/layout/channel_search_row.xml

@@ -44,7 +44,7 @@
             android:layout_marginTop="2dp"
             android:text="@string/subscribe"
             android:textColor="?attr/colorPrimary"
-            android:visibility="gone"/>
+            android:visibility="gone" />
     </LinearLayout>
 
 </LinearLayout>

app/src/main/res/layout/channel_subscription_row.xml

@@ -33,9 +33,10 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentEnd="true"
-        android:backgroundTint="?attr/colorOnPrimary"
+        android:layout_centerVertical="true"
-        android:text="@string/unsubscribe"
+        android:elevation="1dp"
-        android:textColor="@android:color/white"
+        android:text="@string/subscribe"
-        android:textSize="11sp"
+        android:textColor="?android:attr/textColorPrimary"
+        android:textSize="12sp"
         app:cornerRadius="20dp" />
 </RelativeLayout>

app/src/main/res/layout/comments_row.xml

@@ -9,6 +9,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginTop="10dp"
+        android:animateLayoutChanges="true"
         android:orientation="vertical"
         android:paddingStart="20dp"
         android:paddingEnd="20dp"

app/src/main/res/layout/fragment_channel.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <com.github.libretube.views.CustomSwipeToRefresh xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/channel_refresh"
     android:layout_width="match_parent"
@@ -74,15 +75,16 @@
 
                 <com.google.android.material.button.MaterialButton
                     android:id="@+id/channel_subscribe"
+                    style="@style/Widget.Material3.Button.ElevatedButton"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:layout_gravity="center_horizontal"
+                    android:drawableLeft="@drawable/ic_bell_small"
-                    android:backgroundTint="?attr/colorOnPrimary"
+                    android:drawableTint="?android:attr/textColorPrimary"
-                    android:drawableStart="@drawable/ic_bell_small"
+                    android:elevation="20dp"
-                    android:drawableTint="@android:color/white"
                     android:text="@string/subscribe"
                     android:textColor="?android:attr/textColorPrimary"
-                    android:textSize="11sp" />
+                    android:textSize="12sp"
+                    app:cornerRadius="20dp" />
 
             </LinearLayout>
 

app/src/main/res/layout/fragment_player.xml

@@ -279,7 +279,7 @@
                     android:drawableTint="?android:attr/textColorPrimary"
                     android:text="@string/subscribe"
                     android:textColor="?android:attr/textColorPrimary"
-                    android:textSize="12dp"
+                    android:textSize="12sp"
                     app:cornerRadius="11dp" />
             </RelativeLayout>
 
@@ -389,7 +389,7 @@
                 android:id="@+id/rewindFL"
                 android:layout_width="0dp"
                 android:layout_height="match_parent"
-                android:layout_weight=".40">
+                android:layout_weight=".35">
 
                 <ImageButton
                     android:id="@+id/rewindBTN"
@@ -407,14 +407,14 @@
             <LinearLayout
                 android:layout_width="0dp"
                 android:layout_height="match_parent"
-                android:layout_weight=".20" />
+                android:layout_weight=".30" />
 
             <!-- double tap forward btn -->
             <FrameLayout
                 android:id="@+id/forwardFL"
                 android:layout_width="0dp"
                 android:layout_height="match_parent"
-                android:layout_weight=".40">
+                android:layout_weight=".35">
 
                 <ImageButton
                     android:id="@+id/forwardBTN"